1902921 - Home and newtab post v1 we'll need a single pref

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

Right now when we set the wallpaper in v1 we use 2 prefs, and for v2 we set both those prefs the same to keep it simple.

When we remove v1 and consolidate it with v2, we'll want 1 pref.

I think we should consider setting that pref now for v2, even if we're not using it, so when we remove the v1 set of prefs, we don't break it for existing users that set it in v2.

I suspect this is just a matter on deciding on the post v1 pref name, and setting it now when we set the others and keep them in sync. So when we remove the other prefs, we can fully switch to the post v1 single pref and not need to worry about migration.

Comment 1

[Nina Pypchenko [:nina-py]]

Decision made: consolidate the two existing wallpaper prefs:

• browser.newtabpage.activity-stream.newtabWallpapers.enabled
• browser.newtabpage.activity-stream.newtabWallpapers.v2.enabled
  into one (the first one) as with v1 removal referring in the code to v2 is not necessary.

^^^ Taken from review feedback from a related patch on removing dark/light prefs: https://phabricator.services.mozilla.com/D237679

Comment 2

[Nina Pypchenko [:nina-py]]

Attachment: Bug 1902921 - Consolidate New Tab wallpaper preferences r=#home-newtab-reviewers

• Updated New Tab wallpaper code to only use browser.newtabpage.activity-stream.newtabWallpapers.enabled pref for turning the wallpapers on and off.

• Removed usage of browser.newtabpage.activity-stream.newtabWallpapers.v2.enabled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cada12b66300
Consolidate New Tab wallpaper preferences r=home-newtab-reviewers,webdriver-reviewers,whimboo,thecount,reemhamz

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/cada12b66300

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the latest Firefox Nightly 140.0a1 (Build ID: 20250520213629) installed on Windows 10 x64, macOS 15.4.1, and Ubuntu 24.04 x64. I can confirm the following:

• The browser.newtabpage.activity-stream.newtabWallpapers.v2.enabled pref is no longer displayed in the "about:config" page.
• The browser.newtabpage.activity-stream.newtabWallpapers.v2.enabled pref is displayed in the "about:config" page.