1903042 - Tab hover preview will not show from the start after closing some panel menus

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screencast showing the issue

Found in

• Latest Nightly 129.0a1

Affected versions

• Firefox 128.0b3
• Latest Nightly 129.0a1

Tested platforms

• Affected platforms: Windows 11, MacOS 13, Ubuntu 22.04
• Unaffected platforms: None

Preconditions

• have browser.tabs.hoverPreview.enabled set as true

Steps to reproduce

1. Open a few tabs so that tabs can get near the Application Menu (hamburger menu)
2. Add the History button from Customize Toolbar near the Sync/Pocket buttons (other menus can also be used but for some reason not all).
3. Make sure the focus is not in the search bar
4. Click the History button to open the content
5. Click the History button again to close the content of the button and quickly move the cursor to the nearest tab

Expected result

• The tab preview is displayed

Actual result

• The tab preview is not displayed. User has to leave the tab and come back in order for the preview to be displayed.

Regression range

• First bad: 62e0691da30666be17d99e4a59483be053bbddc1 (2024-05-20)
• Last good: aab46451484b9ebfd9e87b248a79c7dd56ae29b7 (2024-05-21)
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aab46451484b9ebfd9e87b248a79c7dd56ae29b7&tochange=62e0691da30666be17d99e4a59483be053bbddc1
• Potentially regressed by: Bug 1897475 - disable tab previews in background windows

Additional notes

• Sometimes the preview will show if moving slower from closing the panel menu to a tab. Also the focus does not necessarily need to be outside of the address bar but it makes reproducing this more often.

Comment 1

[DJ (:dwalker)]

I suspect this is regressed by bug 1878051 and is caused by the context menu being in an animating state and not fully closed, leading to the preview being prevented from showing.

Comment 2

[Jeremy Swinarton]

Attachment: Bug 1903042: THP popups show immediately after closing other panels r?dwalker

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e66fcc0cea0
THP popups show immediately after closing other panels r=dwalker,mconley

Comment 4

[Donal Meehan [:dmeehan]]

Setting Fx129 status to disabled. The status reflects the default, browser.tabs.hoverPreview.enabled is disabled in beta.
This does not block submitting an uplift request if this is needed on beta.

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4e66fcc0cea0

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Verified that this is not reproducible anymore for me using latest Nightly build 130.0a1 across platforms (Windows 11, macOS 13.6 and Ubuntu 22.04).

Comment 7

[Chris Peterson [:cpeterson]]

Too risky to uplift to Beta 129.