190305 - XML prettyprint message can't be localized

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Robert Kaiser]

When we turn on xml pretty printing 
user_pref("layout.xml.prettyprint", true);

and show a xml file without a assigned stylesheet we get this message in the
browser window:

        This XML file does not appear to have any style information
        associated with it. The document tree is shown below.

This message is currently not localizable, though it should be.

The URL field points to the place where this is hardcoded currently (LXR page).

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Prettyprint bugs to Jonas. Please try to take care of this soon. htmlparser/src
has examples on how I did it for XML error messages.

Comment 2

[Asa Dotzler [:asa]]

not gonna hold the release for this. 

Comment 3

[Vincent Béron]

Attachment: Patch to allow XML prettyprint to be localized

This patch allows a XML prettyprint message to be localized.
Requesting review from sicking.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Thanks!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127194 [details] [diff] [review]
Patch to allow XML prettyprint to be localized

>+   - The Initial Developer of the Original Code is
>+   - Netscape Communications Corporation.
>+   - Portions created by the Initial Developer are Copyright (C) 2002
>+   - the Initial Developer. All Rights Reserved.
>+   -
>+   - Contributor(s): Vincent Béron <[e-mail]>

Um.. the initial developer of this particular file is Vincent Beron, no?  And
please encode the non-ASCII char as UTF-8, not as ISO-8859-1.

Also, please use the request tracker to request sr; I realize that the
directions on mozilla.org may not have been updated to reflect this fact....

Comment 6

[Vincent Béron]

Attachment: Patch to allow XML prettyprint to be localized (updated)

Update to attachment #127194 [details] [diff] [review] integrating the changes requested by bzbarsky.

Comment 7

[Axel Hecht]

Comment on attachment 127241 [details] [diff] [review]
Patch to allow XML prettyprint to be localized (updated)

<...>
>+<!ENTITY xml.nostylesheet "This XML file does not appear to have any style information associated with it. The document tree is shown below. Modification.">
<...>

remove " Modification.". with that, r=[e-mail], requesting sr from bz.
I was intending to fix this, no idea that it was just forgotten. Blame sicking.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 127241 [details] [diff] [review]
Patch to allow XML prettyprint to be localized (updated)

>@@ -36,6 +36,8 @@
>    -
>    - ***** END LICENSE BLOCK ***** -->
> 
>+<!DOCTYPE overlay SYSTEM "chrome://communicator/locale/xml/prettyprint.dtd">
>+
> <xsl:stylesheet version="1.0"

This should say <!DOCTYPE xsl:stylesheet...
I'll fix that before checking in.

Comment 9

[Vincent Béron]

>remove " Modification.". with that, r=[e-mail], requesting sr from bz.

That's my fault, results from making sure it did work.

Comment 10

[Emmanuel Bourg]

*** Bug 210880 has been marked as a duplicate of this bug. ***

Comment 11

[Vincent Béron]

Jonas,
I'm sorry for the typo which caused the bustage with my patch. I'll be more
careful next time around (like actually building the thing).

Also, your bigfoot address bounced (tried to go to j_sicking % hotmail), which
was "550: mailbox unavailable".

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

reassigning to Vincent since he fixed the bug

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

...and marking fixed