Closed Bug 1903111 Opened 2 years ago Closed 2 years ago

Expand `searchTermFromResult` to skip strict param matching

Categories

(Firefox :: Search, task, P2)

task

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: jteow, Assigned: jteow)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

Currently, searchTermFromResult checks the input URI matches the URI the engine would've constructed with an equal search term by checking the protocol, origin, path AND params (save the search param).

I'd like to provide the option for a caller to opt in and skip the param check because in some cases, the first two checks are sufficient to match two URIs. The caller can do additional logic that SearchEngine doesn't have to be concerned about, such as manually checking params that might indicate something about the URL.

Blocks: 1902330
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66b0f9e6d158 Expand getSearchTermIfDefaultSerpUri to have skippable param comparisons - r=Standard8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: