1903156 - Remove duplicate code from older menus once the new menus land

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, task, P3)

Description

[Irene Ni [:ini]]

When the new menus are enabled by default and officially released (aiming for Fx 129), the duplicate code for the old Type controls menu and Read aloud menu can be removed from the code-base. This involves going through aboutReader.html, aboutReader.css, NarrateControls.sys.mjs, and VoiceSelect.sys.mjs and removing the code that is executed conditionally only when the reader.improved_text_menu.enabled and reader.colors_menu.enabled prefs are false. We may also want to rename HTML classes and function names so they no longer have the "improved" prefix. aboutReader.ftl and narrate.properties also contain some strings that are no longer used.

Comment 1

[Irene Ni [:ini]]

Attachment: Bug 1903156 - Remove duplicate code from older menus once the new menus land. r=#reader-mode-reviewers

Comment 2

[Irene Ni [:ini]]

After discussion with the team, we have decided to land this patch after 2 release cycles have passed to make sure there is no need to backtrack the new menu updates. @cmkm will handle landing this patch once Fx131 has been released.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6fb7aed437c
Remove duplicate code from older menus once the new menus land. r=reader-mode-reviewers,desktop-theme-reviewers,dao,Gijs

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_readerMode_colorSchemePref.js, browser_parsable_css.js

Backout link

Push with failures - browser_readerMode_colorSchemePref.js
Push with failures - browser_parsable_css.js

Failure log // Failure log 2

Comment 5

[Cieara Meador [:cmkm]]

Clearing NI for Irene who is no longer at Mozilla. I will probably not be able to investigate this until the new year

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e96fd24292b9
Remove duplicate code from older menus once the new menus land. r=reader-mode-reviewers,desktop-theme-reviewers,dao,Gijs

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e96fd24292b9

Comment 8

[Irene Ni [:ini]]

Thanks for your help getting this landed Gijs!