190331 - Hitting enter should not fire oncommand on xul checkboxes

Status: RESOLVED FIXED

Description

[Aaron Leventhal]

Steps:
1. Go to Preferences - Advanced - Keyboard navigation
2. Type Alt+L to toggle links checkbox
3. Select OK to accept pref changes
4. Return to Keyboard navigation panel

Notice that the checkbox state has changed back. The change never took affect.
If you use space bar or click the checkbox it works.

We use oncommand on that checkbox, because the pref is represented by a
bitfield. The oncommand is not being fired.

This may be a dup of bug 90318, or at least it may solve that problem if we fix
this.

Comment 1

[Aaron Leventhal]

Resummarizing -- the problem is that hitting the accesskey clicks and focuses
the checkbox (and correctly fires the oncommand), but hitting Enter for OK is
triggering the oncommand a second time.

Comment 2

[Samir Gehani]

adt: nsbeta1-

Comment 3

[Aaron Leventhal]

The problem is that Enter on a buttonboxframe fires oncommand, whether the
buttonboxframe is really for a button or not -- it could actually be used for a
xul checkbox as well. If it's a checkbox, we don't want to fire oncommand for
Enter key.

This appears to be from

118 hewitt    1.13         if (NS_VK_RETURN == keyEvent->keyCode) {

119 blakeross 1.8             MouseClicked(aPresContext, aEvent);
120                        }

The checkin comment for 1.13 is
1.13 <[e-mail]> 18 Oct 2001 22:02
84602 - when a button has focus, enter key doesn't fire oncommand (from blake),
r=hyatt, sr=hewitt

However, it appears to be blake's patch.

Comment 4

[Aaron Leventhal]

Created attachment 127164 [details] [diff] [review]
Check element to make sure it's a XUL button, before using Enter key for oncommand

Comment 5

[Joe Hewitt (gone)]

Comment on attachment 127164 [details] [diff] [review]
Check element to make sure it's a XUL button, before using Enter key for oncommand

r=hewitt

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 127164 [details] [diff] [review]
Check element to make sure it's a XUL button, before using Enter key for oncommand

sr=jst

Comment 7

[Aaron Leventhal]

Checked into 1.5b trunk.

Comment 8

[[e-mail]]

S'pose the command event could have been done in XBL...

Comment 9

[Aaron Leventhal]

Neil, why do we need a special kind of frame for XUL buttons anyway. Shouldn't
all that functionality be implemented with XBL?