1903416 - Allow for turning off guided notifications for set to default on Windows using a pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

To support the 1-Click Default experiment we want to add a pref that disables guided notifications for set to default on Windows.

A pref that enables 1-click set to default on Windows is already available in-tree (browser.shell.setDefaultBrowserUserChoice.regRename).

Turning off guided notifications with this new pref will only have an effect if the above pref is false (if it's true, users will simply set to default with a single click and do not need to be led to the Windows settings).

We can add a check of the new pref here in ShellService where we determine whether or not to show the guidance notification by sending a trigger message.

We want this to be Nimbus configurable, so it should be added to the feature manifest.

Comment 1

[Meg Viar [:mviar]]

[Tracking Requested - why for this release]: We will uplift this change to support the 1-Click Default experiment planned for launch in 128.

Comment 2

[Jason Prickett]

Attachment: Bug 1903416 - Add a pref to control the display of set default guidance notification

Comment 3

[Meg Viar [:mviar]]

Attachment: Bug 1903416 - Add a pref to control the display of set default guidance notification

Comment 4

[Meg Viar [:mviar]]

Attachment: Bug 1903416 - Add a pref to control the display of set default guidance notification

Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Original Revision: https://phabricator.services.mozilla.com/D214700

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users who enable the 1-click set to default feature via pref will erroneously see a guidance notification when setting to default and users won't be able to participate in our 1-click experiment which will make setting Firefox as a default browser easier for some users
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan in original patch D214700
• Risk associated with taking this patch: Low
• Explanation of risk level: Low risk, this should have no impact on user experience except those enrolled in an upcoming experiment (see comment)
• String changes made/needed: No
• Is Android affected?: no

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1075af143dd
Add a pref to control the display of set default guidance notification r=nrishel,negin

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a1075af143dd

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6a8482a2190

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps provided here and can confirm the following:

• browser.shell.setDefaultGuidanceNotifications to true and browser.shell.setDefaultBrowserUserChoice.regRename to false. In this case, both the Windows Default Apps window and the guidance notification are displayed.
• browser.shell.setDefaultGuidanceNotifications to false and browser.shell.setDefaultBrowserUserChoice.regRename to false. Using this setup the Windows Default Apps window is displayed but the guidance notification is not.
• If the browser.shell.setDefaultGuidanceNotifications pref is set to false and the browser.shell.setDefaultBrowserUserChoice.regRename one to true, then neither the Windows Default Apps window nor the guidance notification is displayed. The browser is set to default using 1-click.
• browser.shell.setDefaultGuidanceNotifications to true and browser.shell.setDefaultBrowserUserChoice.regRename to true. Neither the Windows Default Apps window nor the guidance notification are displayed. Firefox is set to default using 1-click.

Verified using the latest Firefox Nightly 129.0a1 (Build ID: 20240625213230) installed on Windows 10 x64 and Windows 11 x64.