190349 - [junk] - Existing IMAP Junk folder not being marked as Special in new profile

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[esther]

Using trunk build 20030121 on winxp and linux IMAP accounts that already have a
Junk folder marked as special in a different profile cannot be marked as special
in a new profile.  I've tried enabling Junk Controls, dragging messages into the
Junk folder, exit and relaunching.  Nothing worked to convert that existing Junk
folder as Special. I had to Delete the folder then let the new profile create
it's own Junk folder.  This isn't a good experience for the user who uses NS7 at
work and then again at home. 

1. Launch app, create a New Profile
2. Launch mail, add an IMAP account that does not have a folder called Junk and
log in.
3. Enable Junk Mail Controls
Notice you have a Junk folder, now collapse then expand the server to see the
Junk folder become a Special folder.
4. Exit app
5. Launch app, create a New Profile
6. Launch mail, add the same IMAP account and log in
Notice you have the Junk folder but it isn't a Special folder - expected.
7. Enable Junk Mail Controls, notice Junk folder is still not Special.
8. Expand/Collapse server, mark messages as Junk then move them into the folder,
exit and relaunch.  Still the Junk folder is not special

Result- Junk folder can't be marked as a special folder
Expected- Junk folder to become a special folder 

The only way I can get it into special folder status is to delete the folder
then let this profile create it's own special folder.

Comment 1

[esther]

nominating

Comment 2

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 3

[esther]

Note: If user doesn't log into their IMAP account in this new profile (and I
don't know why they would not log in) then Enables JMC when they log into this
account the Junk Mail folder will become special after expanding and collapsing
the twisty.   Note: this is a one time chance to make the existing Junk folder
special for this new profile.

Comment 4

[esther]

Same is true for POP if user already had a folder called "Junk" and for Local
Mail if user already had a folder called "Junk".  Basically the app has to
create it for it to be special and placed with special folders.

Comment 5

[(not reading, please use [e-mail] instead)]

fix in hand.

you'll still have to restart (that's a much bigger bug, involving folder flags
and the folder datasource, which other special folders, like sent and drafts,
should have)

I'll attach the patch.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 7

[(not reading, please use [e-mail] instead)]

fixed.  at least it works better after restart.

this has r/sr=bienvenu.

but there's a couple spin of bugs here.

1)  the generic special folder problems
2)  the special folder will stick (even after restart) for certain folders (like
top level folders named "Junk")

I'll elaborate in the spin off bugs.

Comment 8

[esther]

Using trunk builds 20030314 on winxp, and 20030312 on linux and Mac osx this is
fixed as originally stated. Verified.  However note, I don't have to exit and
relaunch (see comment 5) to see the Special placement and icon I just have to
collapse and expand the twisty for the account.