1903574 - Do not build mfbt tests in the default build

Status: NEW

(Firefox Build System :: General, task, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Currently, if we do a "./mach bootstrap && ./mach build", the tests in mfbt/tests will be built by default.

Some of theses:
mfbt/tests/TestAlgorithm.cpp
mfbt/tests/TestBufferList.cpp
mfbt/tests/TestCasting.cpp
mfbt/tests/TestCheckedInt.cpp
etc

They were probably relevant when C++ wasn't well supported but now, they are probably useless.
Maybe they should be moved to the gtest test suite and executed more rarely

Comment 1

[Mike Hommey [:glandium]]

They were probably relevant when C++ wasn't well supported but now, they are probably useless.

They ensure code in mfbt is not broken when changed. That's not useless.

Maybe they should be moved to the gtest test suite and executed more rarely

This and that are unrelated. Moving them to gtests would create more friction. What's the problem you actually want to solve? From the sound of it, you want to avoid building tests until they're run.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

From the sound of it, you want to avoid building tests until they're run.

More or less
I would like "mach build" not to build them by default. I think they don't provide enough value to be built everytime with Firefox.

Comment 3

[[:sergesanspaille]]

We have --disable-tests for that scenario. unfortunately it's currently broken, but https://bugzilla.mozilla.org/show_bug.cgi?id=1903769 should make it work again. Then the question becomes: should this be the default?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Yeah and enabled in some of the builds in the ci.

Comment 5

[Mike Hommey [:glandium]]

And then you run mach cppunitest and it doesn't work. The way forward would be something like what we do for gtest, and I would even go as far as removing the --disable-test option.