190360 - GRE Uninstall does not remove registry keys

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Charles Rosendahl]

hklm\software\mozilla.org\gre is not removed when uninstalling GRE from
add/remove programs.

Check the version strings(if any) among possible reasons as to why the keys are
being left around.

note a:  the following directory is also left behind - 
program files\mozilla.org\GRE

Comment 1

[Sean Su]

yeah, I just noticed this bug too.  I'm not sure why it's not removing the
windows registry keys.  I was working in all of my test builds before I landed
the patch.

I'll look into it.

Comment 2

[Sean Su]

This should be fixed for 1.3b.  It does not remove any registry keys now.  It
used to work.

I have found the problem.  It's a trivial fix.  It turns out that one of the
lines in the code got accidently deleted.  I have tested the fix and it works again.

1 line patch coming up.

Comment 3

[Sean Su]

Attachment: patch v1.0

the fix is in the uninstaall/parser.c file.

The other two files are only used to help build *test* builds.	They are not
part of anyone's build process.

Comment 4

[Sean Su]

Comment on attachment 112639 [details] [diff] [review]
patch v1.0

the one line fix simply makes sure that the uninstaller is able to parse for
the root key in the following example:
  HKEY_LOCAL_MACHINE\Software\mozilla.org\GRE

without that one line, it was not able to get at just 'HKEY_LOCAL_MACHINE'.

That line was there before.  Just was accidently removed.

Comment 5

[Samir Gehani]

Comment on attachment 112639 [details] [diff] [review]
patch v1.0

We questioned this during the review of bug 186703  and said it was OK but
didn't realize you are parsing from right to left here.

r=sgehani

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 112639 [details] [diff] [review]
patch v1.0

rs=sspitzer

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 112639 [details] [diff] [review]
patch v1.0

sr=dveditz

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 112639 [details] [diff] [review]
patch v1.0

Approving with the assumption that the version changes weren't supposed to be
included.

Comment 9

[Sean Su]

patch checked in.  marking bug fixed.

Comment 10

[Charles Rosendahl]

Verified - base uninstalls (final app depending upon GRE) remove all GRE entries
from the registry in both local machine and current user

20030227 trunk builds.