1903609 - Fix usercharacteristics metrics that break on Fenix

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Fatih Kilic [:fkilic]]

Some data collection functions (screen properties and pointer event) crash Fenix and some don't finish/resolve (content page)

Comment 1

[Fatih Kilic [:fkilic]]

Attachment: Bug 1903609: Reimplement pointer info to capture WidgetEvents. r?timhuang

The previous implementaion used PointerEvent but that was being built from PointerEventHandler::InitPointerEventFrom(Mouse|Touch). The PointerEvent doesn't include the original event, so calling AsTouchEvent() caused failure. We now capture a widget event instead. It may seem like we lost some data, but actually those values were init'ed to 0. Now we collect only data that actually exists.

Comment 2

[Fatih Kilic [:fkilic]]

Attachment: Bug 1903609: Timeout data collections in JS files. r?timhuang

Times out data collections after 5 minutes. I changed all the functions to async to allow awaiting them. I also made FiraSans optional and fail silently if it doesn't exists i.e. on android it doesn't exists. This doesn't resolve Android data collection issue though, for some reason page service never resolves. I'll try to investigate it.

Comment 3

[Fatih Kilic [:fkilic]]

Attachment: Bug 1903609: Move actor registration to UserCharacteristicsPageService.sys.mjs. r?timhuang

Comment 4

[Fatih Kilic [:fkilic]]

So far, pointer event and content page issue is resolved. Only screen properties is left.

Comment 5

[Fatih Kilic [:fkilic]]

Attachment: Bug 1903609: Skip ICEFoundations in automation. r?timhuang

Comment 6

[Fatih Kilic [:fkilic]]

Attachment: Bug 1903609: Skip unavailable screen properties until we find an alternative. r?timhuang

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00f2e924c9f2
Reimplement pointer info to capture WidgetEvents. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/962fe23bb97a
Timeout data collections in JS files. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/e3a3c98b34fd
Move actor registration to UserCharacteristicsPageService.sys.mjs. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/8303598ec6b0
Skip ICEFoundations in automation. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/a93ca984ca88
Skip unavailable screen properties until we find an alternative. r=timhuang

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

---

• Push with failures - build bustages
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/gl/GLContextProviderWGL.cpp(475,8): error: no viable conversion from 'mozilla::CastableTypedEnumResult<CreateContextFlags>' to 'bool'

---

• Push with failures - leak failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck | tab 232 bytes leaked (Mutex, StringBuffer, nsJSPrincipals, nsSimpleURI)

---

• Push with failures - reftests failures
• Failure Log
• Failure line: Assertion failure: NS_IsMainThread(), at /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp:3616

Comment 9

[Fatih Kilic [:fkilic]]

Attachment: Bug 1903609: Collect screen info. r?timhuang

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acc3b15d2526
Reimplement pointer info to capture WidgetEvents. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/fc2913442ba9
Timeout data collections in JS files. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/1c555df47814
Move actor registration to UserCharacteristicsPageService.sys.mjs. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/a7cc58231fc9
Skip ICEFoundations in automation. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/0021392947f7
Skip unavailable screen properties until we find an alternative. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/86784dda5c3d
Collect screen info. r=timhuang

Comment 11

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_usercharacteristics.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/resistfingerprinting/tests/browser/browser_usercharacteristics.js | Test timed out -

Comment 12

[Fatih Kilic [:fkilic]]

I have no idea why the timeout would happen since we didn't get them on try branch. I'll take a look into it. Thank you!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f8422a76c6c
Reimplement pointer info to capture WidgetEvents. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/3cea8e813f4c
Timeout data collections in JS files. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/e137cf3d18d1
Move actor registration to UserCharacteristicsPageService.sys.mjs. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/c5b7a066c350
Skip ICEFoundations in automation. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/72fed4ba1558
Skip unavailable screen properties until we find an alternative. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/0320eea43d38
Collect screen info. r=timhuang

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0f8422a76c6c
https://hg.mozilla.org/mozilla-central/rev/3cea8e813f4c
https://hg.mozilla.org/mozilla-central/rev/e137cf3d18d1
https://hg.mozilla.org/mozilla-central/rev/c5b7a066c350
https://hg.mozilla.org/mozilla-central/rev/72fed4ba1558
https://hg.mozilla.org/mozilla-central/rev/0320eea43d38