190362 - MFCEmbed installer crashing during setup

Status: VERIFIED FIXED

(Core Graveyard :: Installer: MFCEmbed, defect, P1)

Description

[Charles Rosendahl]

Setup is crashing trying to install mfcembed.  Happens fairly immediately after
pressing the 'install' button.

Comment 1

[David G King]

*** Bug 191142 has been marked as a duplicate of this bug. ***

Comment 2

[Sean Su]

Attachment: patch v1.0

Comment 3

[Sean Su]

Comment on attachment 113547 [details] [diff] [review]
patch v1.0

Changes to extra.c are only to check to null pointers, nothing more.

Most of the fix is in the installer build process itself.

Comment 4

[Sean Su]

I don't know if this is a 1.3b blocker.  But I'll request it just in case.  The
main changes were to the mfcembed's installer's build process.

The changes to extra.c were only to check for null pointers.

Chak, once this patch is checked in, mfcembed will probably not start up.  I'm
guessing that it's looking for GRE 1.3a's windows regsitry keys, when we're
installing GRE 1.3b now.

I don't know who's the person to fix that.

Comment 5

[Sean Su]

tryin again to request 1.3b+ status

Comment 6

[Chak Nanga]

MfcEmbed will look at the registry key based on the current Mozilla version.

Please see the usage of MOZILLA_VERSION at:
http://lxr.mozilla.org/seamonkey/source/embedding/tests/mfcembed/winEmbedFileLocProvider.cpp#205

Comment 7

[Sean Su]

Attachment: patch v1.1

new patch with added changes to runapp.bat.  mfcembed installer build script
(makeall.pl) now delivers the updated runapp.bat.  Nothing else changed as
compared to the previous patch.

Comment 8

[Sean Su]

forgot to mention that the fix to runapp.bat allows mfcembed to startup now. 
Runapp.bat updates the search path appropriately, then spawns mfcembed.exe.

Comment 9

[Sean Su]

talked to chak.  he said that mfcembed is not as important as it once was
because mozilla now works with GRE.

This fix can wait till 1.4a.  removing request for 1.3b.

twalker, chak said that you don't need to smoke test mfcembed till 1.4a.

Comment 10

[Chak Nanga]

Eventhough Mozilla uses the GRE it does not use the Gecko embedding APIs like
MfcEmbed does.

So, we still need to get the MfcEmbed installer fixed soon (1.4a) so that Tracy
can test the embedding builds....thanks

Comment 11

[Charles Rosendahl]

Sean has the patch, and gecko qa really needs this fixed asap to continue buffy,
gre, and gecko api testing.

Need to get this in asap.

Comment 12

[Samir Gehani]

Comment on attachment 113558 [details] [diff] [review]
patch v1.1

r=sgehani

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 113558 [details] [diff] [review]
patch v1.1

sr=dveditz

Comment 14

[Sean Su]

Comment on attachment 113558 [details] [diff] [review]
patch v1.1

This patch mainly fixes up the mfcembed's installer build process (script
files), which has nothing to do with mozilla's build process.

The only part that affects mozilla code is a couple places that checks for null
pointers in the win32 installer code.

Other than that, it's pretty harmless but with a lot of gain for mfcembed.

Comment 15

[Sean Su]

patch checked in.  closing bug as fixed.

Comment 16

[Tracy Walker [:tracy]]

verified fixed with mfcembed 2003-02-21-05