190364 - Remove GRE from custom component list in the mozilla installer

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Charles Rosendahl]

GRE is mandatory in order to execute the client, so either disable or remove GRE
in the custom component list when selecting a custom installation in the mozilla
installer.

Removal from the list is preferred.

Comment 1

[Jason Bassford]

Man, that would have been nice to know over the past two days.  Here I thought
that Mozilla was just generally broken.  I didn't realise that GRE was
*required* in order for it to run so I never selected it.  (Until today after
finding out that PSM was now part of it.)

Comment 2

[Chris Neale]

wouldn't it make sense for it to only be an option if not installed already/or
out of date copy ?

Comment 3

[Michael Lefevre]

AIUI, at present, it's always going to be out of date (unless the user is
installing the same version over itself...)

this will confuse everyone, in the same way as PSM did - many people won't
install a component if they don't understand what it is.

Comment 4

[Andrew Hagen]

Yeah, it probably needs to be optional once you've already installed it, but not
optional when it's not currently installed.

Comment 5

[Jason Bassford]

PSM, once installed, was never optional.  The component always appeared as
greyed out.  Since PSM is now part of GRE, shouldn't GRE be similarly greyed out
(and not an option) once its installed the first time?

Also, since Mozilla refuses to start *unless* GRE is install (or at least that's
been my experience since 1/21) why bother showing it at all?  If its lack causes
a crash/hang (or whatever Mozilla not starting is the equivalent of) why bother
showing it at all?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This should definitely be fixed for 1.3beta, and it doesn't sound too hard.

Comment 7

[Brant Gurganus]

Perhaps Navigator is no longer required since GRE is?  That way, people could
just install the components they want on top of the GRE framework?  Or would
that go in a different bug.

Comment 8

[Sean Su]

Attachment: patch v1.0 (ns tree)

Comment 9

[Sean Su]

Attachment: patch v1.0 (moz tree)

Comment 10

[Sean Su]

Brant,

yes it should be filed as a seperate bug.  However, I don't think that having
GRE now relinquishes the browser from being required because this product is
still about installing the "browser".

Comment 11

[Samir Gehani]

Comment on attachment 112723 [details] [diff] [review]
patch v1.0 (ns tree)

r=sgehani based on the assumption that the INVISIBLE attribute only affects UI.

Comment 12

[Samir Gehani]

Comment on attachment 112724 [details] [diff] [review]
patch v1.0 (moz tree)

r=sgehani

Comment 13

[Michael Buckland]

Discussed in edt. Minusing per Charles.  This is an application installer bug.

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 112724 [details] [diff] [review]
patch v1.0 (moz tree)

rs=sspitzer

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 112723 [details] [diff] [review]
patch v1.0 (ns tree)

rs=sspitzer

Comment 16

[Daniel Veditz [:dveditz]]

sr=dveditz

Comment 17

[Sean Su]

patches checked in.  marking bug fixed.

Comment 18

[Grace Bush]

verified - commercial and mozilla builds for 1/28