1903643 - Clear the feature tour pref before rendering a message in about:messagepreview

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Emily McMinn :emcminn]

Right now when we preview feature callouts that use the Feature Tour pref, dismiss buttons and actions tend to not work. This is because these callouts rely on the pref change to trigger navigation/rendering, but once the pref is set it will fail to set again. In the wild the message targeting will prevent this bug, since a message would typically only show once (and then not render again once if the pref is true) but we are overriding targeting for previews.
Clearing the pref before rendering the message should allow everything to behave correctly each time the message is rendered.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1903643 - Clear feature tour prefs for callouts that use them

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2b440d71813
Clear feature tour prefs for callouts that use them r=aminomancer,omc-reviewers

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b2b440d71813