1903775 - Perma browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check the scheme value after blur - "" == "https://" - when Gecko 129 merges to beta on 2024-07-08

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Serban Stanca [:SerbanS]]

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2024-06-20T11:28:21.674Z] 11:28:21     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check the scheme box visibility - "hidden" == "hidden" - 
[task 2024-06-20T11:28:21.674Z] 11:28:21     INFO - Buffered messages finished
[task 2024-06-20T11:28:21.675Z] 11:28:21     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check the scheme value after blur - "" == "https://" - 
[task 2024-06-20T11:28:21.675Z] 11:28:21     INFO - Stack trace:
[task 2024-06-20T11:28:21.675Z] 11:28:21     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js:testVal:60
[task 2024-06-20T11:28:21.675Z] 11:28:21     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js:null:120
[task 2024-06-20T11:28:21.675Z] 11:28:21     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-06-20T11:28:21.676Z] 11:28:21     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-06-20T11:28:21.676Z] 11:28:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-06-20T11:28:21.676Z] 11:28:21     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-06-20T11:28:21.676Z] 11:28:21     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-06-20T11:28:21.676Z] 11:28:21     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js | Check The input field overflow - true == true - 

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1903775 - Perma failure in browser_UrlbarInput_overflow.js on beta merge. r=jteow

My initial assumption about when to show the protocol box were not properly
accounting for the case of a disabled insecure label, and that's why the test
is failing on Beta.
If the insecure label is enabled we never want to show the protocol box, in
the other cases we almost always want to show it, unless the protocol has been
trimmed, or formatting is disabled and we're in active mixed content mode.

All of this won't matter anyway once we start shipping the insecure label by
default, and at a certain point we should remove the pref to disable it.

Comment 2

[Sandor Molnar[:smolnar]]

Patch works in today's beta-sim

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd513de6283d
Perma failure in browser_UrlbarInput_overflow.js on beta merge. r=jteow

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dd513de6283d

Comment 5

[Serban Stanca [:SerbanS]]

Verified fixed in today’s beta simulation push.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1892934