Closed Bug 1903805 Opened 1 month ago Closed 1 month ago

Add additional allowed characters to search-config-icons filter expression pattern

Categories

(Firefox :: Search, defect, P2)

defect

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox127 --- fixed
firefox128 --- fixed
firefox129 --- fixed

People

(Reporter: yazan, Assigned: yazan)

Details

Attachments

(3 files, 1 obsolete file)

Currently, characters like <>()&| are not allowed in the search-config-icons schema's filter expression pattern. This rejects valid expressions such as "env.version|versionCompare("124.0a1")>=0".

Assignee: nobody → yalmacki
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/389fe769c55c
Added additional allowed characters to search-config-icons-schema.json filter expression pattern. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch

This has also been added to remote settings.

Attachment #9408974 - Flags: approval-mozilla-beta?
Attachment #9408974 - Attachment description: Bug 1903805 - Added additional allowed characters to search-config-icons-schema.json filter expression pattern. → WIP: Bug 1903805 - Added additional allowed characters to search-config-icons-schema.json filter expression pattern.

release Uplift Approval Request

  • User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Once remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. Changes can be landed straight away and don't need to wait for a dumps update.
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Limited to schema validation tests only.
  • String changes made/needed: None
  • Is Android affected?: no
Attachment #9408974 - Attachment is obsolete: true
Attachment #9408974 - Flags: approval-mozilla-beta?
Attachment #9408986 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Once remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. However, changes can be landed straight away and don't need to wait for a dumps update.
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Limited to schema validation tests only.
  • String changes made/needed: No
  • Is Android affected?: no
Attachment #9408987 - Flags: approval-mozilla-release?

release Uplift Approval Request

  • User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: nce remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. However, changes can be landed straight away and don't need to wait for a dumps update.
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Limited to schema validation tests only.
  • String changes made/needed: No
  • Is Android affected?: no

release Uplift Approval Request

  • User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Once remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. However, changes can be landed straight away and don't need to wait for a dumps update.
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Limited to schema validation tests only.
  • String changes made/needed: No
  • Is Android affected?: no
Attachment #9408986 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9408987 - Flags: approval-mozilla-release? → approval-mozilla-release+

Nothing actionable for QA here.

Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: