Closed
Bug 1903805
Opened 2 years ago
Closed 2 years ago
Add additional allowed characters to search-config-icons filter expression pattern
Categories
(Firefox :: Search, defect, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
129 Branch
People
(Reporter: yazan, Assigned: yazan)
Details
Attachments
(3 external files, 1 obsolete file)
Currently, characters like <>()&| are not allowed in the search-config-icons schema's filter expression pattern. This rejects valid expressions such as "env.version|versionCompare("124.0a1")>=0".
| Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → yalmacki
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/389fe769c55c
Added additional allowed characters to search-config-icons-schema.json filter expression pattern. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Comment 4•2 years ago
|
||
This has also been added to remote settings.
| Assignee | ||
Comment 5•2 years ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D214401
Updated•2 years ago
|
Attachment #9408974 -
Flags: approval-mozilla-beta?
Updated•2 years ago
|
Attachment #9408974 -
Attachment description: Bug 1903805 - Added additional allowed characters to search-config-icons-schema.json filter expression pattern. → WIP: Bug 1903805 - Added additional allowed characters to search-config-icons-schema.json filter expression pattern.
Comment 6•2 years ago
|
||
release Uplift Approval Request
- User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Once remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. Changes can be landed straight away and don't need to wait for a dumps update.
- Risk associated with taking this patch: Low
- Explanation of risk level: Limited to schema validation tests only.
- String changes made/needed: None
- Is Android affected?: no
Updated•2 years ago
|
Attachment #9408974 -
Attachment is obsolete: true
Attachment #9408974 -
Flags: approval-mozilla-beta?
| Assignee | ||
Comment 7•2 years ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D214401
Updated•2 years ago
|
Attachment #9408986 -
Flags: approval-mozilla-beta?
Comment 8•2 years ago
|
||
beta Uplift Approval Request
- User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Once remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. However, changes can be landed straight away and don't need to wait for a dumps update.
- Risk associated with taking this patch: Low
- Explanation of risk level: Limited to schema validation tests only.
- String changes made/needed: No
- Is Android affected?: no
| Assignee | ||
Comment 9•2 years ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D214401
Updated•2 years ago
|
Attachment #9408987 -
Flags: approval-mozilla-release?
Comment 10•2 years ago
|
||
release Uplift Approval Request
- User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: nce remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. However, changes can be landed straight away and don't need to wait for a dumps update.
- Risk associated with taking this patch: Low
- Explanation of risk level: Limited to schema validation tests only.
- String changes made/needed: No
- Is Android affected?: no
Comment 11•2 years ago
|
||
release Uplift Approval Request
- User impact if declined: No user impact, but required to avoid tests breaking when we publish updates to search-config-icons on production.
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Once remote settings changes to search-config-icons schema are pushed, schema validation tests should keep passing. However, changes can be landed straight away and don't need to wait for a dumps update.
- Risk associated with taking this patch: Low
- Explanation of risk level: Limited to schema validation tests only.
- String changes made/needed: No
- Is Android affected?: no
Updated•2 years ago
|
Attachment #9408986 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•2 years ago
|
status-firefox128:
--- → fixed
Comment 12•2 years ago
|
||
| uplift | ||
Updated•2 years ago
|
Attachment #9408987 -
Flags: approval-mozilla-release? → approval-mozilla-release+
Updated•2 years ago
|
status-firefox127:
--- → fixed
Comment 13•2 years ago
|
||
| uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•