Closed Bug 1903824 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 46845 - webnn: replace DataError with TypeError

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46845 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46845
Details from upstream follow.

Jiewei Qian <qjw@chromium.org> wrote:

webnn: replace DataError with TypeError

The spec had been updated to throw TypeError for failed input
validations: https://github.com/webmachinelearning/webnn/pull/589.

This CL replaces the last remaining DataErrors in lstm implementation and triangular wpt.

Bug: 40206287
Change-Id: I73952ce5b407f2df1d9d3b22c0086638d092e811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5632940
Commit-Queue: Austin Sullivan \<asully@chromium.org>
Reviewed-by: Austin Sullivan \<asully@chromium.org>
Auto-Submit: Jiewei Qian \<qjw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1317381}

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 3 subtests

Status Summary

Firefox

OK : 4
FAIL: 58

Chrome

OK : 4
PASS: 30
FAIL: 28

Safari

OK : 4
FAIL: 58

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webnn/validation_tests/lstm.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] Test with default options: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] Test with given options: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] TypeError is expected if hiddenSize equals to zero: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if hiddenSize is too large: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if steps equals to zero: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the data type is not one of the floating point types: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the rank of input is not 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if input.dimensions[0] is not equal to steps: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the shape of weight is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the rank of recurrentWeight is not 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the size of options.activations is not 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the rank of options.bias is not 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the shape of options.recurrentBias.dimensions is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the dataType of options.peepholeWeight is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the dataType of options.initialHiddenState is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the shape of options.initialCellState is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if weight is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if recurrentWeight is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if bias option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if recurrentBias option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if peepholeWeight option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if initialHiddenState option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if initialCellState option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if any activation option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/lstm.https.any.worker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] Test with default options: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] Test with given options: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] TypeError is expected if hiddenSize equals to zero: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if hiddenSize is too large: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if steps equals to zero: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the data type is not one of the floating point types: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the rank of input is not 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if input.dimensions[0] is not equal to steps: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the shape of weight is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the rank of recurrentWeight is not 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the size of options.activations is not 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the rank of options.bias is not 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the shape of options.recurrentBias.dimensions is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the dataType of options.peepholeWeight is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the dataType of options.initialHiddenState is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] TypeError is expected if the shape of options.initialCellState is incorrect: FAIL (Chrome: FAIL, Safari: FAIL)
    • [lstm] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if weight is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if recurrentWeight is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if bias option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if recurrentBias option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if peepholeWeight option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if initialHiddenState option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if initialCellState option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
    • [lstm] throw if any activation option is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/triangular.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [triangular] TypeError is expected if input's rank is less than 2: FAIL (Chrome: PASS, Safari: FAIL)
    • [triangular] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)
  • /webnn/validation_tests/triangular.https.any.worker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • [triangular] TypeError is expected if input's rank is less than 2: FAIL (Chrome: PASS, Safari: FAIL)
    • [triangular] throw if input is from another builder: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /webnn/validation_tests/lstm.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /webnn/validation_tests/lstm.https.any.worker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /webnn/validation_tests/triangular.https.any.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • /webnn/validation_tests/triangular.https.any.worker.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e7160c2c0ea [wpt PR 46845] - webnn: replace DataError with TypeError, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5e7160c2c0ea

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.