1903827 - Close tab on tabstrip is not providing a context to TalkBack

Status: RESOLVED FIXED

(Firefox for Android :: Tabs, defect, P1)

Description

[Anna Yeddi [:ayeddi]]

Steps to reproduce

1. Ensure a TalkBack is running
2. Open Firefox and confirm the a tab is opened
3. If this is a New Tab:
   1. dismiss the keyboard (until the bug 1902757 is resolved) and, if opened, any OMC onboarding notifications or type in any URL
   2. open any tab, i.e. wikipedia from tiles
4. Open another tab (repeating step 3)
5. With TalkBack, navigate to the first open tab in the tabstrip
6. Using a navigational gesture of TalkBack (swiping left-to-right with one finger, in LTR/English, for instance), navigate to the Close tab button within this tab and observe the TB announcement
7. Repeat steps 5-6 for the second tab and compare the TalkBack announcements for two Close tab buttons.

Expected behavior

1. A context is provided and it is clear, which tab would be closed, when activated.
2. Navigation with TB shortcuts between buttons makes it clear, which tab's Close button is focused

Actual behavior

1. Both buttons are announced the same - Close tab - and it is not clear, which tab would be, in fact, closed if one of them is activated.
2. While navigating with TB shortcuts between buttons, is not clear, which tab's Close button is focused.

Device information

• Firefox version: Nightly 129.0a1 (build #2016026447)
• Android device model: Samsung Galaxy Tab S7+
• Android OS version: 13

Any additional information?

1. The severity of this issue could've been access-S4 if Close buttons would've been hidden when multiple tabs are opened. In that case, i.e. as another major browser does, when only one tab has an on-screen Close button, there are less other options when guessing which tab would be, in fact, closed when this control is activated. But in the situation when there are multiple Close tab buttons present in the reading order, it is hard to navigate to the needed one and make a precise choice. Especially, with the selected/current state information being missed (addressed in bug 1902761)
2. Another major browser on the same device does announce the title of the tab, i.e. Close Wikipedia tab, but another remediation option could be grouping a tab view which currently includes both the tab and its Close button.

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

As a follow up to this accessibility bug, I noticed that a similar thing is happening in the tabs tray (in grid view) but not in the tabs tray (in list view) and I couldn't find an existing bug about this. Would you please follow these steps to reproduce the bug and file another bug if this is an issue? The steps to reproduce (on a phone) are as follows:

Steps to Reproduce

1. Ensure a TalkBack is running
2. Open Firefox and confirm that a tab is opened
3. Open the Tabs Tray and ensure that the tabs view is set to "Grid"
4. If this is a New Tab:
   i. dismiss the keyboard (until the bug 1902757 is resolved) and, if opened, any OMC onboarding notifications or type in any URL
   ii. open any tab, i.e. wikipedia from tiles
5. Open another tab (repeating step 3)
6. With TalkBack, navigate to the first open tab in the Tabs Tray
7. Using a navigational gesture of TalkBack (swiping left-to-right with one finger, in LTR/English, for instance), navigate to the Close tab button within this tab and observe the TB announcement

Actual Behaviour

1. Both buttons are announced the same - Close tab - and it is not clear, which tab would be, in fact, closed if one of them is activated.
2. While navigating with TB shortcuts between buttons, is not clear, which tab's Close button is focused.

Device Information

• Android device model: Samsung A35
• Android OS version: Android 14

Comment 2

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1903827 - Close tab button on Tab Strip is providing a context to TalkBack

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1903827 - Close tab button on Tab Strip is providing a context to TalkBack

Comment 4

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

I was told that the behaviour should be similar in the Tabs Tray grid view so I have filed a bug here

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a31e53c97151
Close tab button on Tab Strip is providing a context to TalkBack r=android-reviewers,007

Comment 6

[Atila Butkovits]

Backed out for causing lint failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a433930b93fc67faae81b2e1135806aac25646d3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a31e53c97151e73cde44a4a8fcad84829e9db4c8&selectedTaskRun=EvbR9KkkRCOs79lyrKIReg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=463968513&repo=autoland

Comment 7

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Thanks for flagging this! Fixing now!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/260a424d4946
Close tab button on Tab Strip is providing a context to TalkBack r=android-reviewers,007

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/260a424d4946