Closed Bug 190395 Opened 22 years ago Closed 22 years ago

main chatzilla prefs panel busted

Categories

(Other Applications :: ChatZilla, defect)

Product:
Other Applications
Component:
ChatZilla
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.3beta

People

(Reporter: durbacher, Assigned: durbacher)

Details

Attachments

(1 file, 1 obsolete file)

patch that adresses additional problem
1.42 KB, patch
rginda
: review+
asa
: approval1.3b+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030123
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030123

This is a regression from 01/22/2003:
rginda's checkin at 01/22/2003 12:56 moved the new chatzilla prefs files in a
subdirectory and modified prefsOverlay.xul to reflect their new location.
But he forgot one of them (pref-irc.xul) when modifying prefsOverlay.xul, which
is the main prefs page for chatzilla.

Reproducible: Always

Steps to Reproduce:
1. "Edit - Preferences - Chatzilla"

Actual Results:  
Only empty page visible.

Expected Results:  
Chatzilla prefs panel visible.

Patch follows.
Adding twpol@aol.com to cc because he wrote the prefs.
Taking.
Status: NEW → ASSIGNED
Really taking, sorry.
Assignee: rginda → durbacher
Status: ASSIGNED → NEW
Attached patch patch (obsolete) — — Splinter Review 
Sets correct path to pref-irc.xul in prefsOverlay.xul.
Comment on attachment 112468 [details] [diff] [review]
patch

Requesting r= from rginda and approval for 1.3b.

Risk: virtually none, path to one file is corrected.

Benefit: you certainly don't want Chatzilla preferences to be totally broken in
1.3b...
Attachment #112468 - Flags: review?(rginda)
Attachment #112468 - Flags: approval1.3b?
Short note: there might be more problems with it, this panel doesn't seem to
remember the prefs.

But: the patch above still does what it is intended to and does not break anything!
Comment on attachment 112468 [details] [diff] [review]
patch

r=rginda
Attachment #112468 - Flags: review?(rginda) → review+
The same modification as in the first patch was also missing at another place.
This patch restores full functionality of the main pref panel.
Attachment #112468 - Attachment is obsolete: true
Attachment #112468 - Flags: approval1.3b?
Summary: main chatzilla prefs panel empty → main chatzilla prefs panel busted
Comment on attachment 112484 [details] [diff] [review]
patch that adresses additional problem

Just as with the first patch (now covers additional issue from comment #5):
Requesting r= from rginda and approval for 1.3b.

Risk: virtually none, path to one file is corrected in two places.

Benefit: you certainly don't want Chatzilla preferences to be totally broken in
1.3b...
Attachment #112484 - Flags: review?(rginda)
Attachment #112484 - Flags: approval1.3b?
Comment on attachment 112484 [details] [diff] [review]
patch that adresses additional problem

r=rginda
Attachment #112484 - Flags: review?(rginda) → review+
Comment on attachment 112484 [details] [diff] [review]
patch that adresses additional problem

a=asa (on behalf of drivers) for checkin to 1.3beta.
Attachment #112484 - Flags: approval1.3b? → approval1.3b+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
v
Severity: normal → major
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.3beta
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: