Closed
Bug 1903952
Opened 11 months ago
Closed 11 months ago
add gtest build in loop-ff.sh
Categories
(Core :: WebRTC, task)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
129 Branch
Tracking | Status | |
---|---|---|
firefox129 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
Details
Attachments
(1 file)
Without building the gtest code we can miss failures that show up later on try builds, specifically for api changes that affect media/webrtc/signaling/gtest/MockCall.h. Adding ./mach build recurse_gtest
after doing ./mach build
adds a little time but avoids having to back-track and find where a simple fix to non-libwebrtc code is required.
Assignee | ||
Comment 1•11 months ago
|
||
Adding this to the build step after each new commit will help
uncover errors that we miss until try builds happen. Specifically,
this shows build errors in media/webrtc/signaling/gtest/MockCall.h
resulting from upstream api changes.
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e078fa0b1691
add './mach build recurse_gtest' to sanity builds. r=ng DONTBUILD
Comment 3•11 months ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•