1903957 - [wpt-sync] Sync PR 46854 - Add DISPLAY_MEDIA_SYSTEM_AUDIO in content settings

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46854 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46854
Details from upstream follow.

Wei Lee <[e-mail]> wrote:

Add DISPLAY_MEDIA_SYSTEM_AUDIO in content settings

This CL is aiming for building up a way to allow WebUI to access the
system audio by default. It enables better user experience for system
web apps on ChromeOS.

To do so, this CL adds a new ContentSettingsType
DISPLAY_MEDIA_SYSTEM_AUDIO so that when an app has this permission,
when calling getDisplayMedia() it can get the system audio
track without going through the display media selection picker.

Here are some consultation bugs we have for this proposal:
[Privacy]: b/337995113
[Security]: b/337996394

Bug: b:337770054
Test: Browser test

Change-Id: I0c7363712a3ca5decdc37e9b10eea5727361e7fa

Reviewed-on: https://chromium-review.googlesource.com/5519954
WPT-Export-Revision: 13e7014118cd9630355a8ff17e6ccce257af739e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6636a06ed807f2864411e8af2fc1ae5eb65f4edf

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d2c468456dc64eab903a787fabc4321015435d2

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 63 subtests

Status Summary

Firefox

OK : 1
PASS: 48
FAIL: 15

Chrome

OK : 1
PASS: 62
FAIL: 1

Safari

OK : 1
PASS: 46
FAIL: 17

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]
  • displaySurface is supported: FAIL
  • getDisplayMedia() with getCapabilities: FAIL
  • getDisplayMedia({"video":{"displaySurface":"monitor"},"monitorTypeSurfaces":"include"}) resolves with a monitor track: FAIL

New Tests That Don't Pass

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]
  • getDisplayMedia({"video":{"displaySurface":"monitor"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"window"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"browser"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • displaySurface is supported: FAIL (Chrome: PASS, Safari: PASS)
  • getDisplayMedia({"selfBrowserSurface":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"surfaceSwitching":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"systemAudio":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"monitorTypeSurfaces":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • suppressLocalAudioPlayback is supported: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"audio":{"suppressLocalAudioPlayback":true}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"audio":{"suppressLocalAudioPlayback":false}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia() with getCapabilities: FAIL (Chrome: PASS, Safari: PASS)
  • getDisplayMedia({"video":{"displaySurface":"monitor"},"monitorTypeSurfaces":"exclude"}) rejects with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"monitor"},"monitorTypeSurfaces":"include"}) resolves with a monitor track: FAIL (Chrome: PASS, Safari: PASS)
  • getDisplayMedia({"monitorTypeSurfaces":"exclude"}) resolves with a non monitor track: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec5922f3a73
[wpt PR 46854] - Add DISPLAY_MEDIA_SYSTEM_AUDIO in content settings, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3ec5922f3a73