Closed
Bug 1904269
Opened 10 months ago
Closed 10 months ago
Remove redundant `menuBuilder` and `private` setting in `DefaultToolbarIntegration.init`
Categories
(Firefox for Android :: Tooling, task, P3)
Tracking
()
RESOLVED
FIXED
129 Branch
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
Details
Attachments
(1 file)
We are effectively calling the following twice:
toolbar.display.menuBuilder = toolbarMenu.menuBuilder
toolbar.private = isPrivate
because it is called in both DefaultToolbarIntegration.init() and ToolbarIntegration.init(). See https://searchfox.org/mozilla-central/rev/783fac5174123467e97fbb955a4ede7eb6e6f419/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt#62-63,93-101,116-117.
We should just rely on the parent class ToolbarIntegration.init() to set the menuBuilder and toolbar and remove the redundant calls in DefaultToolbarIntegration.init().
|
Assignee | |
Updated•10 months ago
|
Summary: Remove reductant `menuBuilder` and `private` setting in `DefaultToolbarIntegration.init` → Remove redundant `menuBuilder` and `private` setting in `DefaultToolbarIntegration.init`
|
|
Assignee | |
Comment 1•10 months ago
|
||
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae52965fe57e
Remove redundant `menuBuilder` and `private` setting in `DefaultToolbarIntegration.init` r=android-reviewers,petru
|
||
Comment 3•10 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•