1904490 - Update android nightly application-services version bump to new version 3ab90b51f742447f60d5f70a3ea0c89763ee8ec2 from 2024-06-25 05:02:53

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 2 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

3ab90b51f742447f60d5f70a3ea0c89763ee8ec2 by Mark Hammond <[e-mail]>

https://github.com/mozilla/application-services/commit/3ab90b51f742447f60d5f70a3ea0c89763ee8ec2
Authored: 2024-06-13 10:31:41 -0400
Committed: 2024-06-24 15:07:55 +0000

Refactor fxa command encryption to avoid duplicated code

Files Added:

• components/fxa-client/src/internal/commands/keys.rs

Files Modified:

• components/fxa-client/src/internal/close_tabs.rs
• components/fxa-client/src/internal/commands/close_tabs.rs
• components/fxa-client/src/internal/commands/mod.rs
• components/fxa-client/src/internal/commands/send_tab.rs
• components/fxa-client/src/internal/device.rs
• components/fxa-client/src/internal/send_tab.rs

---

a8c15ba63d6e8aa187b276372bbdaf414c345e44 by Ben Dean-Kawamura <[e-mail]>

https://github.com/mozilla/application-services/commit/a8c15ba63d6e8aa187b276372bbdaf414c345e44
Authored: 2024-06-12 11:07:54 -0400
Committed: 2024-06-18 17:29:23 +0000

Bug 1901805 - Starting Fakespot ingestion code

Defined the fakespot feature and put most of the changes behind that
feature flag.

Updated ingest code to use 2 remote settings clients, one for fakespot
and one for everything else. I think I like this setup going forward,
since it makes it easy for new suggestions to have their own colleciton
if we decide it makes sense.

Implemented some very simple matching logic, the next step is for the
SNG team to update this with the real matching logic. I tried to leave
FAKESPOT-TODO comment breadcrumbs where they need to update the code.

Files Added:

• components/suggest/src/suggest-fakespot.udl

Files Modified:

• components/suggest/Cargo.toml
• components/suggest/build.rs
• components/suggest/src/benchmarks/client.rs
• components/suggest/src/db.rs
• components/suggest/src/lib.rs
• components/suggest/src/provider.rs
• components/suggest/src/query.rs
• components/suggest/src/rs.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/suggestion.rs
• components/suggest/src/testing/client.rs
• components/suggest/src/testing/data.rs
• components/suggest/src/testing/mod.rs

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=653c218b13fcdabfe62b5f781443372330205416

Comment 2

[Update Bot]

Attachment: Bug 1904490 - Update android nightly application-services version bump to 3ab90b51f742447f60d5f70a3ea0c89763ee8ec2

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cca566e5094
Update android nightly application-services version bump to 3ab90b51f742447f60d5f70a3ea0c89763ee8ec2 r=dmeehan

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4cca566e5094

Comment 5

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• ui-test-apk-fenix-arm-debug - 4 of 4 failed on the same (retriggered) task (failed: PiUM9_3eR3a9JrL0BTRlAA, LQzSWF74SK2fEq-a0IxucA, RN0YWcEwS56lMcIgVEI3UQ, RSwJZ5LETzKN-orK9VMP7g)

Needs Investigation (Possible Intermittents):

• test-components-android-feature-downloads - 2 of 4 failed on the same (retriggered) task (failed: IuJC1eiVTsSSVtyJILlAxw, IM-ddTzeSw2QBmDvJBEFwQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.