Closed Bug 1904609 Opened 1 year ago Closed 1 year ago

Export a python function to get the build id

Categories

(Firefox Build System :: General, enhancement)

enhancement

Tracking

(firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: afranchuk, Assigned: afranchuk)

Details

Attachments

(1 file)

build/variables.py generates the build id, however the function is not idempotent due to the use of datetime.now(). Because of this, python scripts which need the build id end up reading the generated buildid.h file. This happens enough that there should be a function guaranteed to do this correctly if anything about buildid.h changes. Such a function would also make it obvious how to get the build id for future script writers.

Examples:
https://searchfox.org/mozilla-central/rev/64ddb621a0d3905fc2e3df475517d4163d377b22/config/create_rc.py#98
https://searchfox.org/mozilla-central/rev/64ddb621a0d3905fc2e3df475517d4163d377b22/toolkit/library/gen_buildid.py#39
https://searchfox.org/mozilla-central/rev/64ddb621a0d3905fc2e3df475517d4163d377b22/toolkit/crashreporter/tools/symbolstore.py#594

Pushed by afranchuk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b7f9d14221a Provide a function to get the build id r=glandium
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: