Closed Bug 1904905 Opened 2 years ago Closed 2 years ago

Remove `nsNavHistoryContainerResultNode::ReverseUpdateStats`

Categories

(Toolkit :: Places, task, P3)

task

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [sng])

Attachments

(1 external file)

Summarizing what I posted in Bug 1904682, nsNavHistoryContainerResultNode::ReverseUpdateStats doesn't seem to be useful today.

Its primary scope is to update ancestors of a container when the mTime or mAccessCount of the container change.
Though, so far, I couldn't find a single case where that is necessary today.

The scope of this method is to update ancestors' mTime and mAccessCount when a
container mTime or mAccessCount is updated, though we have no cases where that
actually benefits any UI view or feature today.
Indeed queries flatten down children (there's just a few query of queries),
while bookmark folders don't even report any value for mTime or mAccessCount in
the UI. So the only case for this update, that is to sort containers by last
visit date or visit count, is nonexisting.
This is also confirmed by the fact no test is failing removing it, that seems
to indicate test coverage for this was sub-par from the beginning.

Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/fd2f6af55908 Remove `nsNavHistoryContainerResultNode::ReverseUpdateStats`. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Whiteboard: [sng]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: