1904909 - PlacesUtils::GatherDataText and GatherDataHtml should not recurse into queries

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak]]

GatherDataText and GatherDataHTML recurse into containers to build a string representation of a node, with the scope of being able to paste or drop a list of URIs into a receiver app/field.
There is no protection against building a too large string or recursing too much here.
I think at first stance we could allow recursion only for real folders, as you can't build infinite structures with folders. That will limit a bit the reach of the feature, but one can still copy the first level of a query or a tag. And when one is copying a root shortcut, we'll allow to recurse into folders, but not into other queries or shortcuts.
One can always export bookmarks as json or html anyway when they need a full tree.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1904909 - PlacesUtils::GatherDataText and GatherDataHtml should not recurse into queries r=daisuke

There's a few problems in the code gathering text data for nodes.
First it should not recurse into queries (included folder shortcuts) as it's
easy to create infinite recursion with them. The first level is excluded though,
as otherwise it would not be possible to copy contents of left pane roots.
Second it should requery folder shortcut contents in excludeItems results,
as otherwise it's not possible to copy contents of a root as text.
There's no longer the risk of dragging around root folders as this code is only
used for text flavors today, drag&drop uses serializeNode instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa13edbcc74
PlacesUtils::GatherDataText and GatherDataHtml should not recurse into queries r=daisuke,places-reviewers

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5fa13edbcc74