1904926 - [wpt-sync] Sync PR 46916 - Add support for quotes in @page margin boxes content.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46916 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46916
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Add support for quotes in @page margin boxes content.

Since quotes create an extra level of layout objects, it will no longer
be a simple LayoutBlockFlow (page margin box) with leaf nodes, so that
the existing IsDetachedNonDomRoot() would fail when building the layout
object tree. Therefore change this flag (which is only used when DCHECKs
are enabled) to be set for the entire non-DOM tree, rather than just on
its root.

Bug: 40341678
Change-Id: Ie5e9ca34491b42dcff9ad029aa0fe8fedcce45ef
Reviewed-on: https://chromium-review.googlesource.com/5658437
WPT-Export-Revision: c9de0838e2e588c76d5f9deb0f2749970d57534e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec85dc07488663a437cbf88d1fa4f9aa9974d8f4

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-page/margin-boxes/content-002-print.html [wpt.fyi]: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abb055e77b54
[wpt PR 46916] - Add support for quotes in @page margin boxes content., a=testonly
https://hg.mozilla.org/integration/autoland/rev/e3fc52e44714
[wpt PR 46916] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/abb055e77b54
https://hg.mozilla.org/mozilla-central/rev/e3fc52e44714