190495 - Find As You Type shouldn't start on XUL Tree Views (e.g., about:config, XUL Directory Listings)

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect, P2)

Description

[Aaron Leventhal]

about:config uses a tree view -- it's not HTML.
Find As You Type shouldn't start up there.

Comment 1

[Greg K.]

Also encountered using FizzillaMach/2003012403 to access about:config and FTP
directory listings with XUL Directory Listings enabled. Revising Summary and
setting All/All.

To reproduce:
1. Access about:config
2. Select an item
3. Press the 'a' key

Expected results:
Nothing should happen (or should it?)

Actual results:
'Link not found: "a" repeated' displayed on Status Line.

(See also bug 190533.)

Comment 2

[alanjstr]

Is there any way to search a tree view?  Type Ahead Find doesn't seem to do
anything in my about:config.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20030125 Phoenix/0.5

Comment 3

[Aaron Leventhal]

A temporary workaround is to turn off the pref "Find automatically when typing
within a web page" in the Prefs -> Advanced -> Keyboard Navigation prefs.

This shows what the keyboard navigation would be like if this bug were fixed.

Note that there's still a problem with the tab order: it takes 2 tabs to get to
the point where you can arrow around the tree view, or use tree view's
navigate-by-printable character features. Meanwhile, the focus isn't visible
until 1 of the items gets selected. I think we'll have to file a separate bug on
that.

Comment 4

[Aaron Leventhal]

Attachment: Uses solution proposed by jst -- check QI to nsIDOMXULDoc, use mime type to make sure it's not an ascii doc when auto link search is on

Also fixes bug 189193, auto link search shouldn't be attempted in ascii text
doc

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 112830 [details] [diff] [review]
Uses solution proposed by jst -- check QI to nsIDOMXULDoc, use mime type to make sure it's not an ascii doc when auto link search is on

sr=jst

Comment 6

[[e-mail]]

Nice, all I need know is auto text search on plain text documents :-P

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 112830 [details] [diff] [review]
Uses solution proposed by jst -- check QI to nsIDOMXULDoc, use mime type to make sure it's not an ascii doc when auto link search is on

>+
>+  nsCOMPtr<nsIDOMXULDocument> xulDoc(do_QueryInterface(doc));
>+  if (xulDoc) {
>+    return NS_OK; // Avoid xul tree views, svg and other non-docs

How exactly does this code avoid "svg and other non-docs"?

>+  }
>+
>+  if (mLinksOnlyPref) {
>+    nsAutoString contentType;
>+    doc->GetContentType(contentType);
>+    if (contentType.Equals(NS_LITERAL_STRING("text/plain"))) {
>+      return NS_OK; // No auto link search in plain text pages
>+    }
>+  }

Comment 8

[Aaron Leventhal]

My fault, we decided not to avoid svg, because it can have links in it.

I'll just fix the comment.

Comment 9

[Aaron Leventhal]

Christopher,

I have the comment changed to accurate reflect what it does. We decided not to
change SVG.

I'll put up a new patch if you ask for it.

- Aaron

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

What does the new comment read?

Comment 11

[Aaron Leventhal]

+    return NS_OK; // Avoid any xul docs, whether in chrome or content

Comment 12

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 112830 [details] [diff] [review]
Uses solution proposed by jst -- check QI to nsIDOMXULDoc, use mime type to make sure it's not an ascii doc when auto link search is on

Okay, r=caillon with the corrected comment you just posted.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 112830 [details] [diff] [review]
Uses solution proposed by jst -- check QI to nsIDOMXULDoc, use mime type to make sure it's not an ascii doc when auto link search is on

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 14

[Aaron Leventhal]

checked in

Comment 15

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.02.12 comm trunk bits (tested with about:config) on linux
rh8.0, win2k and mac 10.2.3.

Comment 16

[Vaclav Dvorak]

Hmmm... I wouldn't quite say that this is fixed. With 2003031216/Win98, I see
the following:
1) Load about:config, _don't_ click on any pref entry. Press slash - status bar
says 'Starting -- find text as you type'. Press "a" - status bar says 'Text not
found: "a" repeated'. Press "s" - no visible change. Press "d" - status bar now
says 'Text not found: "asd"'. Nothing else apparently happens besides changing
the status bar. This may be bug 190533, I guess. But that's not all:
2) With about:config still loaded, click on a pref entry to focus it, then press
slash. After about a second, 'Starting -- find text as you type' appears in the
status bar and a tiny, two-pixel caret starts blinking in the upper left corner
of the content area. Now, press "a". The highlight in the XUL view moved as it
should, but also the status bar says 'Text not found: "a" repeated'.