Closed Bug 1904975 Opened 1 year ago Closed 1 year ago

Enable async stacks for xpcshell tests

Categories

(Testing :: XPCShell Harness, defect)

Product:
Testing
Component:
XPCShell Harness
Version:
Default
Platform:
Desktop
All
Type:
defect

Tracking

(firefox130 fixed)

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: markh, Assigned: markh)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1904975 - allow xpcshell tests to have full async stacks. r?Standard8
48 bytes, text/x-phabricator-request
Details | Review

Like bug 1822618 but for xpcshell tests.

eg, before:

 0:07.25 pid:33516 _generateAndPersistCommandKeys@resource://gre/modules/FxAccountsCommands.sys.mjs:357:23
 0:07.25 pid:33516 _generateAndPersistEncryptedCommandKey@resource://gre/modules/FxAccountsCommands.sys.mjs:388:32
 0:07.25 pid:33516 _do_main@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:245:6
 0:07.25 pid:33516 _execute_test@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:596:5
 0:07.25 pid:33516 @-e:1:1

after:

 0:07.33 pid:34015 _generateAndPersistCommandKeys@resource://gre/modules/FxAccountsCommands.sys.mjs:357:23
 0:07.33 pid:34015 _generateAndPersistEncryptedCommandKey@resource://gre/modules/FxAccountsCommands.sys.mjs:388:32
 0:07.33 pid:34015 async*getEncryptedCommandKeys@resource://gre/modules/FxAccountsCommands.sys.mjs:442:20
 0:07.33 pid:34015 async*availableCommands@resource://gre/modules/FxAccountsCommands.sys.mjs:58:55
 0:07.33 pid:34015 _registerOrUpdateDevice@resource://gre/modules/FxAccountsDevice.sys.mjs:433:35
 0:07.33 pid:34015 async*updateDeviceRegistration/<@resource://gre/modules/FxAccountsDevice.sys.mjs:282:20
 0:07.33 pid:34015 async*_withCurrentAccountState/<@resource://gre/modules/FxAccountsDevice.sys.mjs:311:22
 0:07.33 pid:34015 withCurrentAccountState@resource://gre/modules/FxAccounts.sys.mjs:784:22
 0:07.33 pid:34015 _withCurrentAccountState@resource://gre/modules/FxAccountsDevice.sys.mjs:309:23
 0:07.33 pid:34015 updateDeviceRegistration@resource://gre/modules/FxAccountsDevice.sys.mjs:276:17
 0:07.33 pid:34015 updateDeviceRegistration@resource://gre/modules/FxAccounts.sys.mjs:1607:24
 0:07.33 pid:34015 setSignedInUser@resource://gre/modules/FxAccounts.sys.mjs:1019:16
 0:07.33 pid:34015 async*MockFxAccounts@/Users/skip/src/moz/gecko-2/obj-releasebuild/_tests/xpcshell/services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js:170:23
 0:07.33 pid:34015 test_updateDeviceRegistration_with_new_device@/Users/skip/src/moz/gecko-2/obj-releasebuild/_tests/xpcshell/services/fxaccounts/tests/xpcshell/test_accounts_device_registration.js:187:21
 0:07.33 pid:34015 _run_next_test/<@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:1759:22
 0:07.33 pid:34015 _run_next_test@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:1759:38
 0:07.33 pid:34015 run@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:808:9
 0:07.33 pid:34015 _do_main@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:245:6
 0:07.33 pid:34015 _execute_test@/Users/skip/src/moz/gecko-2/testing/xpcshell/head.js:596:5
 0:07.33 pid:34015 @-e:1:1
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8aa397a1ad76 allow xpcshell tests to have full async stacks. r=Standard8

Backed out for causing xpcshell failures in test_ext_native_messaging.js.

Flags: needinfo?(markh)
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4634cc9ddc9c allow xpcshell tests to have full async stacks. r=Standard8

Backed out for causing xpcshell failures on test_ext_native_messaging.js

[task 2024-07-03T17:18:56.595Z] 17:18:56     INFO -  TEST-START | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js
[task 2024-07-03T17:19:06.133Z] 17:19:06  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | xpcshell return code: 0
[task 2024-07-03T17:19:06.134Z] 17:19:06     INFO -  TEST-INFO took 9536ms
[task 2024-07-03T17:19:06.134Z] 17:19:06     INFO -  >>>>>>>
[task 2024-07-03T17:19:06.134Z] 17:19:06     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-07-03T17:19:06.134Z] 17:19:06     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-07-03T17:19:06.134Z] 17:19:06     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-07-03T17:19:06.134Z] 17:19:06     INFO -  running event loop
[task 2024-07-03T17:19:06.135Z] 17:19:06     INFO -  toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | Starting setup check_remote
[task 2024-07-03T17:19:06.135Z] 17:19:06     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2024-07-03T17:19:06.135Z] 17:19:06     INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - false == false
Flags: needinfo?(markh)

oops, I neglected to update phabricator so pushed the exact same version as before, resulting in the backout for the exact same reason.

Flags: needinfo?(markh)
Blocks: 1907190
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe8e80591dc3 allow xpcshell tests to have full async stacks. r=Standard8,extension-reviewers,willdurand

https://hg.mozilla.org/mozilla-central/rev/fe8e80591dc3

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: