1905095 - Loosen the heuristic for detecting visibility of ads to at least 50% of its height and/or width

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

If the an ad is not 100% visible, SERP Telemetry v1 does not add it ads_visible. This can lead to confusing results where an ad mostly shows up but is slightly below the fold and thus doesn't get counted.

Additionally, ads far to the left could be carousel elements that were viewed. A carousel can also partially obscure the last viewable element on the right so we could apply the threshold in that case to include that as a viewed element.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1905095 - Loosen the heuristic for ads_visible - r?standard8!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27d8d901feca
Loosen the heuristic for ads_visible - r=Standard8

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/27d8d901feca

Comment 4

[James Teow [:jteow]]

Comment on attachment 9410317 [details]
Bug 1905095 - Loosen the heuristic for ads_visible - r?standard8!

Beta/Release Uplift Approval Request

• User impact if declined: Data Science won't see changes to recorded search telemetry (namely, whether an ad was viewed when the search telemetry impression was recorded) until 130.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes only affect search telemetry.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9410317 [details]
Bug 1905095 - Loosen the heuristic for ads_visible - r?standard8!

Approved for 129.0b3

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/366cb8b71cf3