1905289 - The subresource loads for ABA context should be keyed with foreign ancestor bit

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Tim Huang[:timhuang]]

We don't apply the foreign ancestor bit when loading subresource loads for ABA contexts. Considering the following case,

example.com-(embeds)->third-party.com-(subresource load)->example.com

The subresource is keyed by example.com, but not example.com,f (I ignore the scheme here). We should apply the foreign ancestor bit to the subresource load in this case.

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

I have a patch with tests coming now...

Kicking off a try run to be certain too.

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1905289 - The subresource loads for ABA context should be keyed with foreign ancestor bit - r=timhuang!

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

https://treeherder.mozilla.org/jobs?repo=try&revision=72b3c8ce9370cd6bf3584107efddb435614ff735

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b7e3b44a1a1
The subresource loads for ABA context should be keyed with foreign ancestor bit - r=timhuang,anti-tracking-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in test_CrossSiteXHR_cache.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/security/test/cors/test_CrossSiteXHR_cache.html | should have failed in test for {"pass":0,"method":"GET","headers":{"x-my-header":"myValue","y-my-header":"second"}} (index 8) - got false, expected true

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/deb04f42bc8d
Backed out changeset 1b7e3b44a1a1 for causing mochitests failures in test_CrossSiteXHR_cache.html.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e90e7d21561
The subresource loads for ABA context should be keyed with foreign ancestor bit - r=timhuang,anti-tracking-reviewers

Comment 8

[Benjamin VanderSloot [:bvandersloot]]

Fixing that test. I thought I fixed it already from a try run. Sorry sheriff!

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7e90e7d21561