Closed
Bug 190529
Opened 22 years ago
Closed 22 years ago
create linux sdk tar.gz file
Categories
(SeaMonkey :: Build Config, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3beta
People
(Reporter: leaf, Assigned: leaf)
Details
Attachments
(1 file, 1 obsolete file)
|
1.98 KB,
patch
|
kysmith
:
review+
netscape
:
superreview+
asa
:
approval1.3b+
|
Details | Diff | Splinter Review |
We create an embed-i686-pc-linux-gnu.tar.gz file, but no sdk tar.gz that
developers can write apps against.
The fix is to tar.gz dist/sdk and spit it out.
|
||
Comment 1•22 years ago
|
||
this is for browser embedding, correct?
|
||
Comment 2•22 years ago
|
||
it is for browser component development and embedding applications.
|
|
Assignee | |
Comment 3•22 years ago
|
||
i should add cls for review on this. i probably did it badly.
|
|
||
Updated•22 years ago
|
Priority: -- → P3
Target Milestone: --- → mozilla1.4alpha
|
|
Assignee | |
Updated•22 years ago
|
Attachment #112553 -
Flags: superreview?(seawood)
Attachment #112553 -
Flags: review?(kysmith)
|
|
||
Comment 4•22 years ago
|
||
Comment on attachment 112553 [details] [diff] [review]
add an sdk tar.gz generation when we make "normal" .tar.gz packages.
I would suggest making a separate target for creating the sdk and add $(SDK) to
TARGETS.
Attachment #112553 -
Flags: superreview?(seawood) → superreview-
|
|
Assignee | |
Comment 6•22 years ago
|
||
Attachment #112553 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #113128 -
Flags: superreview?(seawood)
Attachment #113128 -
Flags: review?(kysmith)
|
|
||
Comment 7•22 years ago
|
||
Comment on attachment 113128 [details] [diff] [review]
better?
yep. sr=cls
Attachment #113128 -
Flags: superreview?(seawood) → superreview+
|
|
||
Updated•22 years ago
|
Attachment #113128 -
Flags: review?(kysmith) → review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #113128 -
Flags: approval1.3b?
|
|
Assignee | |
Comment 8•22 years ago
|
||
relatively innocuous change, trying for 1.3b
Target Milestone: mozilla1.4alpha → mozilla1.3beta
|
||
Comment 9•22 years ago
|
||
Comment on attachment 113128 [details] [diff] [review]
better?
a=asa (on behalf of drivers) for checkin to 1.3beta.
Attachment #113128 -
Flags: approval1.3b? → approval1.3b+
|
|
Assignee | |
Comment 10•22 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 11•22 years ago
|
||
Comment on attachment 113128 [details] [diff] [review]
better?
>Index: Makefile.in
>@@ -124,6 +130,9 @@
> TAR_CREATE_FLAGS = -cvf
> PLATFORM_EXCLUDE_LIST = ! -name "*.ico"
> endif
>+
>+$(SDK):
>+ cd $(DIST); if [ -d $(SDK_DIR) ]; then $(MAKE_SDK); fi
>
> $(PACKAGE): $(MOZILLA_BIN)
> @rm -rf $(DIST)/$(MOZ_PKG_APPNAME) $(DIST)/$(PKG_BASENAME).tar $@ $(EXCLUDE_LIST)
Duh. New lines have new subshells, have to put this all one one line, instead
of two.
a=dbaron on comment 11
|
|
||
Updated•22 years ago
|
Attachment #112553 -
Flags: review?(kysmith)
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•