190529 - create linux sdk tar.gz file

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Daniel (Leaf) Nunes]

We create an embed-i686-pc-linux-gnu.tar.gz file, but no sdk tar.gz that
developers can write apps against.

The fix is to tar.gz dist/sdk and spit it out.

Comment 1

[Jon Granrose]

this is for browser embedding, correct?

Comment 2

[Doug Turner (:dougt)]

it is for browser component development and embedding applications.

Comment 3

[Daniel (Leaf) Nunes]

Attachment: add an sdk tar.gz generation when we make "normal" .tar.gz packages.

i should add cls for review on this. i probably did it badly.

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 112553 [details] [diff] [review]
add an sdk tar.gz generation when we make "normal" .tar.gz packages.

I would suggest making a separate target for creating the sdk and add $(SDK) to
TARGETS.

Comment 5

[Daniel (Leaf) Nunes]

thanks, i'll fix.

Comment 6

[Daniel (Leaf) Nunes]

Attachment: better?

Comment 7

[hacker formerly known as [e-mail]]

Comment on attachment 113128 [details] [diff] [review]
better?

yep. sr=cls

Comment 8

[Daniel (Leaf) Nunes]

relatively innocuous change, trying for 1.3b

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 113128 [details] [diff] [review]
better?

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 10

[Daniel (Leaf) Nunes]

checked in.

Comment 11

[Daniel (Leaf) Nunes]

Comment on attachment 113128 [details] [diff] [review]
better?

>Index: Makefile.in
>@@ -124,6 +130,9 @@
> TAR_CREATE_FLAGS = -cvf
> PLATFORM_EXCLUDE_LIST = ! -name "*.ico"
> endif
>+
>+$(SDK):
>+	cd $(DIST); if [ -d $(SDK_DIR) ]; then $(MAKE_SDK); fi
> 
> $(PACKAGE): $(MOZILLA_BIN)
> 	@rm -rf $(DIST)/$(MOZ_PKG_APPNAME) $(DIST)/$(PKG_BASENAME).tar $@ $(EXCLUDE_LIST)


Duh. New lines have new subshells, have to put this all one one line, instead
of two.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron on comment 11