190534 - Help buttons in Account Settings pointing to wrong location in Help

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[robinf]

Win 2K Commercial trunk Build ID 2003012408:

For IMAP, POP, and News Offline & Disk Space settings in Account Settings, the
Help button in each of these three panels points to the wrong location in Help.

Steps to reproduce:
1. Open Mail/News Account Settings.
2. Select any one of the following:
-Offline & Disk Space for IMAP account
-Offline & Disk Space for News account
-Disk Space for POP account
3. Click Help button.
Actual results: Help window opens to "Setting Up Your Accounts for Working Offline"

Expected results:
-Offline & Disk Space for IMAP account: should point to help topic "Offline and
Disk Space Settings (IMAP)"
-Offline & Disk Space for News account: should point to help topic "Offline and
Disk Space Settings (News)"
--Disk Space for POP account: should point to help topic "Disk Space Settings (POP)"

Here's how to make the Help button in each panel point to the right place:

Account Settings panel for Offline & Disk Space for IMAP account--
Help button context info:
 <rdf:li> <rdf:Description ID="mail_offline_imap" nc:name="IMAP" 
nc:link="chrome://help/locale/mail_help.html#OFFLINE_IMAP"/> </rdf:li>

Account Settings panel for Offline & Disk Space for News account--
Help button context info:
 <rdf:li> <rdf:Description ID="mail_offline_nntp" nc:name="News" 
nc:link="chrome://help/locale/mail_help.html#OFFLINE_NEWS"/> </rdf:li>

Account Settings panel for Disk Space for POP account--
Help button context info:
 <rdf:li> <rdf:Description ID="mail_offline_pop3" nc:name="POP" 
nc:link="chrome://help/locale/mail_help.html#OFFLINE_POP"/> </rdf:li>

nominating for next release

Comment 1

[Brant Gurganus]

these are documentation issues, not Help browser issues

Comment 2

[robinf]

This is a regression, possibly related to the Help button code in the Account
Settings dialog for these options. The help Description IDs already exist in the
help TOC (help-toc.rdf) and content (mail_help.html). 

Re-assigning to Seth for the fix.

Comment 3

[robinf]

changing product to MailNews.

Comment 4

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 5

[Sean Su]

Attachment: patch v1.0

Comment 6

[Sean Su]

Attachment: patch v1.1

The problem is that the logic to build the correct help tag, depending on which
type of account pref the user is getting help for, is not reached because it's
keying off of "mail" instead of "mail" || "mail-offline-accounts".

Comment 7

[jag (Peter Annema)]

Comment on attachment 121508 [details] [diff] [review]
patch v1.1

sr=jag

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 121508 [details] [diff] [review]
patch v1.1

r=dmose

Comment 9

[Sean Su]

Comment on attachment 121508 [details] [diff] [review]
patch v1.1

trivial patch. not risky.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 121508 [details] [diff] [review]
patch v1.1

a=sspitzer

Comment 11

[Sean Su]

fix checked in.

Comment 12

[Ninoschka Baca]

Trunk build 2003-05-22: Mac 10.1.5, WinMe
Verified Fixed.

I changed qa contact from Rudman to nbaca. I hope that's ok.