1905342 - [wpt-sync] Sync PR 46930 - Page margin at-rule CSSOM support.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46930 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46930
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Page margin at-rule CSSOM support.

Add the CSSMarginRule interface, which is available via the CSSRuleList
cssRules member inside a CSSPageRule.

Parsing of CSS margin rules is protected by the feature flag
PageMarginBoxes, so unless that feature is enabled, the list of margin
rules will always be empty.

Bug: 324827379
Change-Id: I76da73a4b98a276ee59533993f52511bca72a42f
Reviewed-on: https://chromium-review.googlesource.com/5301160
WPT-Export-Revision: d0a81ac2b2a283a3c258cb8fd96dacd45ab98335

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=de3c4ab001edb43598384720f3592a3a5aabf625

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 2 subtests

Status Summary

Firefox

OK : 2
PASS : 2
FAIL : 4
ERROR: 1

Chrome

OK : 2
PASS : 2
FAIL : 4
ERROR: 1

Safari

OK : 2
PASS : 1
FAIL : 5
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-page/cssom/margin-001.html [wpt.fyi]
  • Rule #1: FAIL (Chrome: FAIL, Safari: FAIL)
  • Rule #2: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-page/cssom/margin-002.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
• /css/css-page/cssom/margin-003.html [wpt.fyi]
  • Insert rules: FAIL (Chrome: FAIL, Safari: FAIL)
  • Delete rules: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b59cec9a0a63
[wpt PR 46930] - Page margin at-rule CSSOM support., a=testonly
https://hg.mozilla.org/integration/autoland/rev/90952cfc1ec1
[wpt PR 46930] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b59cec9a0a63
https://hg.mozilla.org/mozilla-central/rev/90952cfc1ec1