Closed Bug 1905496 Opened 8 months ago Closed 6 months ago

Event/Task reminder has confusing number in sleep duration units

Categories

(Thunderbird :: General, defect)

Thunderbird 129
defect

Tracking

(thunderbird_esr115 unaffected, thunderbird_esr128 unaffected, thunderbird129 affected, thunderbird130 affected)

RESOLVED FIXED
131 Branch
Tracking Status
thunderbird_esr115 --- unaffected
thunderbird_esr128 --- unaffected
thunderbird129 --- affected
thunderbird130 --- affected

People

(Reporter: kevin, Assigned: aleca)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

In Thunderbird Daily (build 20240628164427), the drop-down for snoozing an event or task notification includes the default amount in the duration unit drop-down: Specifically, the drop-down has "5 minutes", "5 hours", "5 days" instead of "minutes", "hours", "days" as it previously did. This is confusing, especially because the number in the unit drop-down does not change with the amount spinner, so clicking up once results in "6" "5 minutes", as shown in the attached screenshot.

Steps to reproduce:

  1. Create a New Task (Ctrl+D) with title "Test Task", start "2024-06-29 8:00am", and reminder "0 minutes before"
  2. After pressing "Save and Close" a notification for "Test Task" should appear.
  3. Click the "Snooze for" button and observe "5 minutes" in the drop-down.

I've bisected the issue to https://hg.mozilla.org/comm-central/pushloghtml?fromchange=3696a5582c30943986c838967a271afbdfd0329a&tochange=235dfb49109fce5662792182d08e8007956d16ae

Perhaps Bug 1893758 is the regressor?

Hello,

Confirming that I have reproduced this issue on Windows 11, macOS 14 and Ubuntu22 with 129.0b1((20240708223515) and 130.0a1(20240709104114). Issue is not present in 128.0esr(20240709010607) nor 115.13.0(20240709183211).

Also managed to confirm that this issue is a regression as stated in the comment above. Below is the relevant regression information:

pushlog_URL
Confirming that the culprit of this regression could be : bug 1893758

Status: UNCONFIRMED → NEW
Ever confirmed: true

Thanks Kevin. Please set actual version number of what you are using when reporting, or the oldest known version which reproduces.

Version: Trunk → Thunderbird 129

Wayne, can you clarify what you mean? I set the version to Trunk, since it reproduced on the latest nightly. I bisected and provided the regression range . You are asking me to also try testing beta and release versions, then set the version to the oldest version as well?

Actually, since 129.0b1 became available on 2024-07-11 and I submitted the issue on 2024-06-29, I'm not sure what I could have done differently. Would you have preferred I select "Thunderbird 129" before it had been released? For example, if I found a bug in Daily right now which is not present in 129.0b1, should I set "Version: Thunderbird 130"?

Flags: needinfo?(vseerror)

Sorry I don't mean to complicate things. Having an actual version umber helps with bug queries, among other things.

Whether something is released or not doesn't matter for bugzilla purposes, it will help to set the version to what you are running. Or having a regression range, to the version you suspect it starts at. If the flag for a version you are reporting doesn't yet exist, then please state that in your reporting comments.

Does that help?

Flags: needinfo?(vseerror)

Thanks Wayne, I think so. If I understand correctly, you would have liked me to have set "Version: Thunderbird: 129" for this issue, even though a beta for 129 had not been released yet, since the issue did not affect the beta for 128. Is that correct?

Should I set the status flags as well, or leave that for the QA folks? I don't want to step on anyone's toes or mess up the triage process.

Correct, release status is not relevant - what matters is the version of the code.

If you have access to flags and understand their usage then go for it, the help will be appreciated.

Keywords: regression
Regressed by: 1893758
Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Target Milestone: --- → 130 Branch

Pushed by solange@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/d8300a0ffdb6
Fix incorrect unit strings for time based menuitems. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Attachment #9414379 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9413716 - Attachment description: Bug 1905496 - Fix incorrect unit strings for time based menuitems. r=#thunderbird-reviewers → Bug 1905496 - Fix incorrect unit strings for time based menuitems and add missing fluent files. r=#thunderbird-reviewers
Target Milestone: 130 Branch → 131 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/8a6ca28e1cf2
Fix incorrect unit strings for time based menuitems and add missing fluent files. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 7 months ago6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: