Closed
Bug 1905634
Opened 1 year ago
Closed 1 year ago
Incorrect usage of preprocessor conditionals around media engine prefs
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
129 Branch
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
It looks to me like there's a mistake in the conditionals that landed in bug 1901084 around media-engine prefs. The symbol DEV_EDITION_OR_EARLY_BETA_OR_EARLIER that was created there is always #defined (either as true or false), which would be fine if used as the value of a boolean pref (like we do with other similarly-defined IS_... symbols). But using it in an #if defined(...) test will not have the intended effect, because whether it's true or false, it is defined in either case.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84a6b4d37c01
Fix usage of conditionals around media engine prefs in StaticPrefList.yaml. r=alwu
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•