1905675 - Clean up IntersectionObserver setup.

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1905675 - Clean up IntersectionObserver set-up. r=smaug!

UpdateIntersectionObservation takes some time (see profile in blocked
bug). It it needs to do multiple hashmap lookups unnecessarily.

We can store the observation state in the IntersectionObserver object
and remove the bespoke intersectionobserverlist property, using
BindObject / UnbindObject to keep stuff alive, like ResizeObserver and
MutationObserver do.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1905675 - Clean up IntersectionObserver set-up. r=smaug!

UpdateIntersectionObservation takes some time (see profile in blocked
bug). It it needs to do multiple hashmap lookups unnecessarily.

We can store the observation state in the IntersectionObserver object
and remove the bespoke intersectionobserverlist property, using
BindObject / UnbindObject to keep stuff alive, like ResizeObserver and
MutationObserver do.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdd47955cc10
Clean up IntersectionObserver set-up. r=smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0dd464f3c45
Remove assert that doesn't hold during unlink and was introduced by the previous patch.

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/fdd47955cc10
https://hg.mozilla.org/mozilla-central/rev/b0dd464f3c45