1905766 - [meta] Cleanup tests/manifests affected by sidebar.revamp pref once flipped on by default

Status: NEW

(Firefox :: Sidebar, task, P2)

Description

[Kelly Cochrane [:kcochrane]]

As part of bug 1897976, I've updated all existing tests that are failing once the sidebar.revamp pref has been flipped on in the following ways:

• Created a secondary manifest file titled browserSidebarRevamp.toml with the sidebar.revamp pref set to true
• Updated test files affected by the pref flip to add conditionals for when the pref is set to true

Once the pref has been flipped on by default, we should do some cleanup by removing conditionals in these tests and consolidate the manifest file back into the original browser.toml and remove the pref from the top of that manifest file.

Comment 1

[Sam Foster [:sfoster] (he/him)]

I got some try results to highlight the failures we might expect when we flip the pref by default. We have a number of tests that expect the legacy sidebar which disable sidebar.revamp to pass and we'll need to look at each of these.
We might want to invert the sidebar test manifest situation so we run all tests with sidebar.revamp=true and isolate just specific tests where we really want coverage for the legacy sidebar up until the moment we remove it entirely.

I'll make this a meta bug and file individual bugs to break up this into smaller bite-size tasks.