Open Bug 1905791 Opened 1 year ago Updated 1 year ago

Stop calling EndDragSession when initiating drag suppression

Categories

(Core :: DOM: Copy & Paste and Drag & Drop, task)

Product:
Core
Component:
DOM: Copy & Paste and Drag & Drop
Type:
task

Tracking

()

People

(Reporter: handyman, Unassigned)

Details

In patch review discussion here, it was noted that nsBaseDragSession::Suppress calling EndDragSession isn't really supported (only the OS/user can actually end a drag session). Beyond that, no longer respecting the drag can lead to a bad user experience. The call also causes a lot of secondary bugs that have led to some additional work-arounds. The discussion notes that we might not need Suppress to call EndDragSession -- it's two use cases are (1) suppressing initiating a drag session on certain mousedowns to avoid allowing a page to generate a drag session by moving the window underneath it (bug 329385) and (2) pointer lock. Case (1) obviously doesn't need the call to EndDragSession (and it is the one that causes most of the issues). Case (2) might want to call EDS -- but it can call EDS on its own if that's the case.

You need to log in before you can comment on or make changes to this bug.