1905803 - Enable l10n strings from thunderbird-l10n

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

Bug to actually use the strings in thunderbird-l10n.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1905803 - Use Github thunderbird-l10n for strings. r=#thunderbird-build-system-reviewers

Comment 2

[BMO Github Automation]

Attachment: [mozilla-releng/scriptworker-scripts] Bug 1905803 - Enable l10n_bump_github action for comm trust domain. (#1048)

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1905803 - Switch l10n_bumper to use thunderbird-l10n repo. r=#thunderbird-build-system-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a764a437807
Switch l10n_bumper to use thunderbird-l10n repo. r=dandarnell

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1905803 - Allow l10n_bumper cron job to run on comm-central. r=#releng-reviewers

Comment 6

[Rob Lemley [:rjl]]

Attachment: Bug 1905803 - Enable l10n_bumper on comm central. r=#thunderbird-build-system-reviewers

Comment 7

[BMO Github Automation]

Attachment: [mozilla-releng/fxci-config] Bug 1905803 - Allow l10n_bumper cron job to run on comm-central. (#45)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a471e335e982
Use Github thunderbird-l10n for strings. r=dandarnell
https://hg.mozilla.org/comm-central/rev/1a94c4c035fb
Enable l10n_bumper on comm central. r=dandarnell

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9416667 [details]
Bug 1905803 - Enable l10n_bumper on comm central. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
L10n migration to Github. Requesting late beta uplift so that this is on comm-release post-merge on 2024-08-05.
Request is for 5a764a437807, a471e335e982, and 1a94c4c035fb.

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9416667 [details]
Bug 1905803 - Enable l10n_bumper on comm central. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
L10n move to Github. Not needed until 128.1.1+
Request is for 5a764a437807, a471e335e982, and 1a94c4c035fb.

[Approval Request Comment]
Needed for 115.15.0 - I will provide an esr115 patch prior to building.

Comment 11

[Corey Bryant]

Comment on attachment 9416667 [details]
Bug 1905803 - Enable l10n_bumper on comm central. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Corey Bryant]

Comment on attachment 9416667 [details]
Bug 1905803 - Enable l10n_bumper on comm central. r=#thunderbird-build-system-reviewers

Switching flags back to approval-comm-esr128? and approval-comm-esr115? so that we don't pick these up earlier than expected.

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 129.0b6+:
https://hg.mozilla.org/releases/comm-beta/rev/3d503d9ce6d2
https://hg.mozilla.org/releases/comm-beta/rev/a2b45b2bdbc2
https://hg.mozilla.org/releases/comm-beta/rev/4e2303ccc048

Comment 14

[Rob Lemley [:rjl]]

Attachment: comm_esr115_l10n-bugs.patch

[Approval Request Comment]
This patch combines the 3 patches on this bug as well as bug 1905802 and a final patch to l10n-changesets.json and is specific to comm-esr115.
This change has been on Daily for about a week and on 130.0b1 and 129.0rc monthly have been verified working via manual inspection.

Comment 15

[Rob Lemley [:rjl]]

Attachment: comm_esr128_l10n-changesets.patch

[Approval Request Comment]
For comm-esr128, uplift from this bug and bug 1905802 the following changesets in this order:

• 5a764a437807
• 7b6cbb5340b0 (bug 1905802)
• a471e335e982
• 1a94c4c035fb

Then apply this patch to update l10n-changesets.json with a Git revision.

Comment 16

[Corey Bryant]

Comment on attachment 9417821 [details] [diff] [review]
comm_esr115_l10n-bugs.patch

[Triage Comment]
Approved for esr115

Comment 17

[Corey Bryant]

Comment on attachment 9417822 [details] [diff] [review]
comm_esr128_l10n-changesets.patch

[Triage Comment]
Approved for esr128

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 115.14.1:
https://hg.mozilla.org/releases/comm-esr115/rev/1e330ce82289
https://hg.mozilla.org/releases/comm-esr115/rev/8538ea4ae6d7
https://hg.mozilla.org/releases/comm-esr115/rev/792237232c38
https://hg.mozilla.org/releases/comm-esr115/rev/a04554fae6b6

https://hg.mozilla.org/releases/comm-esr115/rev/7e088929fa16cd84daa8b53e687cf9c710a4d917 (followup)

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 128.1.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/ea76c403f1a2
https://hg.mozilla.org/releases/comm-esr128/rev/337e46c56b81
https://hg.mozilla.org/releases/comm-esr128/rev/fef40da35eeb
https://hg.mozilla.org/releases/comm-esr128/rev/1c6958e4739a

Comment 20

[Magnus Melin [:mkmelin]]

Is this supposed to bump l10n-changesets.json automatically on 128? That does not seem to be happening (128 still uses an old pinning)

Comment 21

[Rob Lemley [:rjl]]

(In reply to Magnus Melin [:mkmelin] from comment #20)

Is this supposed to bump l10n-changesets.json automatically on 128? That does not seem to be happening (128 still uses an old pinning)

It's not supposed to update on esr or release.

The logic behind that makes sense with a monthly stable release cadence -- as translators work through backlogs, they can see the results of their efforts in daily and beta. This never quite made sense for Thunderbird's yearly stable releases though.

I think this is a good idea though. It's a matter of when and how. I generally try to bump for minor versions for the first six months at least, but I'm a forgetful human...