Normal/Active tab page button is wrong color (black-on-dark-gray, with bad contrast), in dark mode after recent refactor
Categories
(Fenix :: Tabs, defect, P1)
Tracking
(firefox127 unaffected, firefox128 unaffected, firefox129 verified, firefox130 verified)
Tracking | Status | |
---|---|---|
firefox127 | --- | unaffected |
firefox128 | --- | unaffected |
firefox129 | --- | verified |
firefox130 | --- | verified |
People
(Reporter: 007, Assigned: npoon)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fxdroid][group4][ux-fun-2024])
Attachments
(2 files)
12.44 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
|
Details | Review |
The Normal/Active tab page button is not being properly colored by the TabRow
+ Tab
component.
The tabCounterAlpha
val
just needs to get moved to within the Tab
block at line 236 for it to get the correct LocalContentColor
within the localized context of the selected/unselected state of the Tab
.
This can be verified using the Compose preview inside the file.
Comment 1•8 months ago
|
||
Set release status flags based on info from the regressing bug 1890849
:tchoh, since you are the author of the regressor, bug 1890849, could you take a look?
For more information, please visit BugBot documentation.
Comment 2•8 months ago
|
||
Note: visually this is only noticeable in dark mode right now. Updating summary to mention that, to help catch possible dupes before they're filed. (I nearly filed one just now.)
If possible, it'd be great to either fix this or backout the regressor before 129 rides the trains to beta on Monday.
Assignee | ||
Updated•7 months ago
|
Updated•7 months ago
|
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 4•7 months ago
|
||
Assignee | ||
Comment 5•7 months ago
|
||
Comment on attachment 9411544 [details]
Bug 1906001 - Get correct colour for Normal/Active tab page button on Tabs Tray in dark mode
Beta/Release Uplift Approval Request
- User impact if declined: Accessibility issue in dark mode
- Is this code covered by automated tests?: Unknown
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1. Set Fenix to dark mode
- Open the Tabs Tray and observe the Tab Counter in the top left of the Tabs Tray
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch just requires changing where a variable is initialized in a local function.
- String changes made/needed:
- Is Android affected?: Unknown
Assignee | ||
Updated•7 months ago
|
Comment 7•7 months ago
|
||
bugherder |
Comment 9•7 months ago
•
|
||
Comment on attachment 9411544 [details]
Bug 1906001 - Get correct colour for Normal/Active tab page button on Tabs Tray in dark mode
Approved for 129.0b2
Comment 10•7 months ago
|
||
uplift |
Updated•7 months ago
|
Comment 11•7 months ago
|
||
Managed to reproduce the issue on the previous Nightly build (130.0a1 from 2024-07-09) and the current Beta (129.0b1).
Verified on the latest Nightly build 130.0a1 from 2024-07-10.
The tab counter is now the correct color in dark mode.
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as verified on 130.
Leaving the qe-verify+ flag to verify this on 129.0b2.
Updated•7 months ago
|
Comment 12•7 months ago
•
|
||
Verified on the latest Beta build 129.0b2.
The tab counter is now the correct color in dark mode.
Devices used:
- OnePlus 3 A3000 (Android 6).
- Samsung Galaxy S23 Ultra (Android 14).
- Google Pixel 7 (Android 15 Beta 3).
Marking the ticket as verified on 129 as well.
Updated•7 months ago
|
Updated•7 months ago
|
Updated•5 months ago
|
Description
•