1906108 - upgrade markus to 5.0.0 and add metrics yaml file

Status: RESOLVED FIXED

(Socorro :: Antenna, task, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Markus 5.0.0 includes a RegisteredMetricsFilter (docs) which allows us to document all the metrics that Antenna emits with descriptions and types and then enforce only those metrics are emitted during tests. This reduces typos in metrics keys, makes it easier to see our metrics situation, and makes it easier to build dashboards without hunting through code for the name of the thing you forgot.

I prototyped this with Eliot in this pull request:

https://github.com/mozilla-services/eliot/pull/169

I liked the way that felt. The docs are handy:

https://mozilla-eliot.readthedocs.io/en/latest/metrics.html

We should upgrade Markus and write up a metrics yaml file for Antenna.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/antenna] bug-1906108: upgrade markus to 5.0.0 and document metrics (#1052)

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/antenna]: bug-1906108: upgrade markus to 5.0.0 and document metrics (#1052) in 68b1d2f.

I updated the sentry_scrub_error panel in the Socorro GCP app metrics dashboard.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to prod just now in bug #1915154. Marking as FIXED.