Closed Bug 1906207 Opened 7 months ago Closed 2 months ago

Remove font styling from moz-message-bar

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: mstriemer, Assigned: mkennedy)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file)

The moz-message-bar.css styles are setting the text color and line height.

Both rules can be removed, the line height one can be replaced with 1lh when used for setting height/padding and doesn't need to be set for line-height

Reasoning:
The text color should be inherited from the parent setting a font for this component.

The line height shouldn't be necessary anymore since we can use the lh CSS unit to perform the calculations that the line height was being set for

Assignee: nobody → mkennedy
  • Remove message-bar-text-color CSS var

  • Remove message-bar-text-line-height CSS var in favor of 1lh

Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd2fbfb7cf64 Remove message-bar-text-color and message-bar-text-line-height CSS vars r=reusable-components-reviewers,desktop-theme-reviewers,hjones
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Regressions: 1935250
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: