19066 - Breaker/Seperator drawn on Go menu when it shouldn't be

Status: VERIFIED WONTFIX

(Core :: XUL, defect, P5)

Description

[Andrew Niese]

Start Apprunner and do not browse to any sites.
Click the GO menu. Since you have not browsed anywhere, only Back, Forward, and
Home menu items should be present.

Underneath "home" is a Menu seperator ("menu break"), which need not be there
because nothing is underneath it.

m11 win32

Comment 1

[Peter Trudelle]

I assume this should be handled by the app code, not the menu code.  reassigning
to don

Comment 2

[don]

Radha ...

Comment 3

[don]

Move to M21 target milestone.

Comment 4

[Radha on family leave (not reading bugmail)]

I'm giving this to Blake. I think he can handle this.

Comment 5

[Blake Ross]

I recall Matthew saying awhile ago wrt the bookmarks menu that perhaps such 
separators should stay (even if it is awkward for a menu to end with a 
separator), because it shows that the menu can include more items.  cc'ing him 
for comment

Comment 6

[Matthew Tuck [:CodeMachine]]

If you're going to go down that path you should just put in some disabled text
explaining what should go there.  Ending with a separator is extremely ugly.

But in this case, I would imagine we always should be visiting a page, even if
it's "about:blank".

Comment 7

[Matthew T (active 1999-2002)]

4.7 for Mac OS does end the `Go' menu with a separator in the same situation.
But in build 2000111520, I don't get a menu ending with a separator, I get a
menu ending with `about:blank'.

The title shouldn't be `about:blank' (it should probably be `[Blank]' or
something), but otherwise I think the current behavior may be appropriate. I
guess it depends on how often (if ever) you want to go back to about:blank after
visiting stuff in a window. Thoughts?

Comment 8

[Blake Ross]

I assume you have your homepage set to `Blank page'?  I also don't see the menu 
ending with a separator -- it has whatever you have your homepage set to.  But 
if you have your homepage set to a non-existent site, you'll get an error when 
you start the browser, and the Go menu does, indeed, end with a separator in 
that case.  So are we fixing that or not?  I don't want to morph this into an 
`about:blank shouldn't be on Go menu' bug (but please feel free to file another 
bug on me for that issue, if you want).

Comment 9

[Matthew T (active 1999-2002)]

Ok, so leave the separator there then. Same reasoning as for the Bookmarks menu: 
the presence of the separator indicates that the menu could very easily contain 
more items than it does right now.

Comment 10

[Blake Ross]

ok then.

Comment 11

[Matthew Tuck [:CodeMachine]]

This might have been fixed since it was reported.  I suggest the non-existant
site problem should be filed somewhere.  Maybe it should be fixed by redirecting
to about:blank or similar.

Comment 12

[sairuh (rarely reading bugmail)]

mass-verifying WontFix bugs which haven't changed since 2001-12-31.

use the search string "BoletusEdulis" if you want to filter out this msg.