1906649 - GfxInfo::Init() doesn't check the return value of PR_sscanf

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Andrew McCreight [:mccr8]]

See here. It looks like maybe this function should fail if PR_sscanf fails.

Comment 1

[Jamie Nicol [:jnicol]]

Is this causing an actual issue for you, and if so, what is the use case?

If PR_sscanf fails then mWindowsVersion will remain the default kWindowsUnknown, which seems reasonable to me. I'm not sure if failing gfxInfo initialisation is preferable to that. Perhaps people using MOZ_GFX_SPOOF_WINDOWS_VERSION would like it to be obvious if they for example have a typo causing it to not act as intended, but equally perhaps they may like the ability to spoof an unknown version.

Comment 2

[Andrew McCreight [:mccr8]]

No, this is not causing an issue. I was looking over the places that don't check the return value because of bug 265693. That does sound like a reasonable default.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1906649 - Ignore the return value of PR_sscanf in GfxInfo::Init().

Init() is only called once after GfxInit is initially created, so
if PR_sscanf fails then the values of mWindowsVersion and
mWindowsBuildNumber will remain at their default values, which
are reasonable.

Comment 4

[Andrew McCreight [:mccr8]]

It is a little inconsistent here because this method does explicitly set mWindowsVersion to kWindowsUnknown if GetVersionEx fails but eh not a big deal.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d048b8e3e5ef
Ignore the return value of PR_sscanf in GfxInfo::Init(). r=gfx-reviewers,win-reviewers,gstoll,jnicol

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d048b8e3e5ef