1906652 - "Jump back in" and "Task continuity" CFR and the Wallpaper tool are not triggered with the Navigation Toolbar disabled

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Lorand Janos]

Preconditions

Have a clean profile.
Make sure the Navigation Toolbar is disabled from Secret Settings.

Steps to reproduce

1. Visit a page and go back to Homescreen.
2. Observe the Jump back in CFR.
3. Visit a second page and go back to Homescreen.
4. Observe the Wallpaper selection tool triggered.
5. Perform a sync with at least 1 tab opened on the second device.
6. Observe the task continuity CFR triggered.

Expected behavior

All the popups are displayed correctly.

Actual behavior

None of the mentioned popups from steps 2, 4 and 6 are displayed.

Device information

• Firefox version: Nightly 129.0a1 from 2024-07-08.
• Android device model: Samsung Galaxy S23 Ultra
• Android OS version: Android 14.

Comment 1

[[:skhan]]

Attachment: Bug 1906652 - Fix Jump back/Sync CFR and Wallpaper tool triggers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7dae4715ccd
Fix Jump back/Sync CFR and Wallpaper tool triggers r=android-reviewers,tchoh

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/a7dae4715ccd

Comment 4

[Lorand Janos]

This issue is no longer reproducible on the latest Nightly build (130.0a1 from 2024-07-10).
The Jump back in and the task continuity CFRs and Wallpaper selection tool are now all triggered as expected.
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as verified on 130.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:skhan, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[[:skhan]]

Comment on attachment 9411540 [details]
Bug 1906652 - Fix Jump back/Sync CFR and Wallpaper tool triggers

Beta/Release Uplift Approval Request

• User impact if declined: Won't see Jump back in/Sync CFRs and wallpaper on-boarding tool.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Has been tested in nightly.
• String changes made/needed: No
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9411540 [details]
Bug 1906652 - Fix Jump back/Sync CFR and Wallpaper tool triggers

Approved for 129.0b3

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5733e0ec0128

Comment 9

[Lorand Janos]

Verified as fixed on the latest Beta build (129.0b3).
The Jump back in and the task continuity CFRs and Wallpaper selection tool are now all triggered as expected.
Device used: Samsung Galaxy S23 Ultra (Android 14).
Marking the ticket as verified on 129 as well.