1906734 - Use WEBEXT_URI_WEB_ACCESSIBLE for MV2 extensions

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

Currently there is extra work done for MV2 extensions to use different flags than MV3 extensions or themes. This is unnecessary, as the checks which would be performed if the WEBEXT_URI_WEB_ACCESSIBLE flag is set will also work for MV2 extensions.

This bug is to clean up this extra check for MV2 extensions to use the same codepath for both MV2 and MV3.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1906734 - Switch WebExtension resources to use only static protocol flags, r=#extension-reviewers!,#necko-reviewers!

Previously, the WebExtension protocol used dynamic protocol flags which
were based on the WebExtension policy in order to enforce things such as
availability in private browsing and the accessibility of certain
resources.

Since the shift to MV3, these checks have required more complex checks
than what was possible to specify with protocol flags, which required
the addition of WEBEXT_URI_WEB_ACCESSIBLE - a security flag which would
trigger further checks with the EPS to determine if the URI can be
loaded.

This was somewhat inefficient, as fetching the URI flags would require
looking up the policy each time dynamic flags were looked up, as well as
when policy specifics were being checked after loading flags. In
addition, it lead to a number of flags which were very specific to
extension protocols.

This patch changes extensions to no longer have dynamic flags, instead
specifying the static URI_IS_WEBEXTENSION_RESOURCE security flag. When
this flag is specified, security checks are made by querying the
ExtensionPolicyService to ask if the load should be permitted, combining
the specific security checks for Extension resources into a simpler
code-path, and avoids redundant checks.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec8bc0625f7
Switch WebExtension resources to use only static protocol flags, r=extension-reviewers,necko-reviewers,kershaw,robwu

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/aec8bc0625f7