190678 - Right Clicking on Personal Toolabr gives js error

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Start Phoenix, right click on personal toolbar. This error is displayed in the 
console:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "aSelection has no properties" 
{file: "chrome
://browser/content/bookmarks/bookmarks.js" line: 719}]' when calling method: 
[ns
IController::isCommandEnabled]"  nsresult: "0x80570021 
(NS_ERROR_XPC_JAVASCRIPT_
ERROR_WITH_DETAILS)"  location: "JS frame :: 
chrome://global/content/globalOverl
ay.js :: goUpdateCommand :: line 53"  data: yes]
************************************************************

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: fix - null check

null check selection in case the bookmark toolbar object's command controller's
isCommandEnabled method is called when a selection does not exist (in this
case, the edit menu update was calling this.)

Comment 2

[Pierre Chanial]

*** Bug 172029 has been marked as a duplicate of this bug. ***

Comment 3

[Pierre Chanial]

fixed

Comment 4

[noririty]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/components/bookmarks/content&command=DIFF_FRAMESET&file=bookmarksToolbar.xml&rev1=1.39&rev2=1.40&root=/cvsroot
v.