1906792 - More cleanup related to intrinsic size

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See the patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1906792 Part 1 - Let nsLeafFrame and subclasses override GetIntrinsicSize(). r?#layout

nsIFrame already provides GetIntrinsicSize() for subclasses to override.
Therefore, nsLeafFrame doesn't need to introduce another version for its
subclasses.

This patch (hopefully) shouldn't change the behavior.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1906792 Part 2 - More cleanup for nsLeafFrame. r?#layout

• Expand SizeToAvailSize() at callsites since it is only used twice, and the
  callsites already have called SetOverflowAreasToDesiredBounds().
• Revise obsolete comment for nsLeafFrame.
• Remove redundant virtual keyword.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1906792 Part 3 - Move ContainIntrinsicISize() calls into IntrinsicISize() helper for flex and grid container. r?#layout

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1906792 Part 4 - Add IntrinsicISize() helpers to implement GetMinISize()/GetPrefISize(). r?#layout

These frames have very similar implementations in GetMinISize() and
GetPrefISize(). Therefore, add helpers to avoid code duplication. The helpers
are named IntrinsicISize() to match existing helpers in flex & grid container.

Drop "Get" in GetIntrinsicISize() for nsFieldSetFrame and
nsComboboxControlFrame to match our coding style because it always returns a
value.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16a4be98c3a0
Part 1 - Let nsLeafFrame and subclasses override GetIntrinsicSize(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/e9f1397f7667
Part 2 - More cleanup for nsLeafFrame. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/321316df53f0
Part 3 - Move ContainIntrinsicISize() calls into IntrinsicISize() helper for flex and grid container. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/70c615f711f3
Part 4 - Add IntrinsicISize() helpers to implement GetMinISize()/GetPrefISize(). r=layout-reviewers,emilio

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/16a4be98c3a0
https://hg.mozilla.org/mozilla-central/rev/e9f1397f7667
https://hg.mozilla.org/mozilla-central/rev/321316df53f0
https://hg.mozilla.org/mozilla-central/rev/70c615f711f3