nsMsgDBFolder backup database isn't closed if the normal database is already closed
Categories
(MailNews Core :: General, defect)
Tracking
(thunderbird_esr128+ fixed, thunderbird129 fixed)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
(Blocks 1 open bug)
Details
(Keywords: memory-leak)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
corey
:
approval-comm-esr128+
|
Details | Review |
In this folder clean-up code nsMsgDBFolder::Shutdown
, mBackupDatabase
is only closed and nulled out if mDatabase
exists. Apparently, it's possible for mBackupDatabase
to exist when mDatabase
doesn't. This happens in local folder repair, and browser_repairFolder.js reports a leak of a bunch of database, folder, and message objects.
Assignee | ||
Comment 1•7 months ago
|
||
Assignee | ||
Updated•7 months ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0dd3a34992d1
Always close backup database in nsMsgDBFolder::Shutdown. r=BenC DONTBUILD CLOSED TREE
Updated•7 months ago
|
Comment 3•7 months ago
|
||
Comment on attachment 9411732 [details]
Bug 1906835 - Always close backup database in nsMsgDBFolder::Shutdown. r=BenC
[Triage Comment]
Approved for beta so we can get this to 128 quickly.
Comment 4•7 months ago
|
||
bugherder uplift |
Thunderbird 129.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/47b77cd42e3b
Comment 5•6 months ago
|
||
Geoff, We'd like to pick this up in 128.1.0esr. Please let us know if you have any concerns with shipping this.
Comment 6•6 months ago
|
||
Comment on attachment 9411732 [details]
Bug 1906835 - Always close backup database in nsMsgDBFolder::Shutdown. r=BenC
[Triage Comment]
Approved for esr128
Comment 7•6 months ago
|
||
bugherder uplift |
Thunderbird 128.1.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/18ebd7d4ceac
Updated•6 months ago
|
Description
•